From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shile Zhang <shile.zhang@linux.alibaba.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc/pvpanic: Export module FDT device table
Date: Thu, 18 Feb 2021 11:00:21 +0100 [thread overview]
Message-ID: <YC46tZLAesfSNg40@kroah.com> (raw)
In-Reply-To: <20210218094024.69354-1-shile.zhang@linux.alibaba.com>
On Thu, Feb 18, 2021 at 05:40:24PM +0800, Shile Zhang wrote:
> Export the module FDT device table to ensure the FDT compatible strings
> are listed in the module alias. This help the pvpanic driver can be
> loaded on boot automatically not only the ACPI device, but also the FDT
> device.
>
> Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
> ---
> drivers/misc/pvpanic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> index 41cab297d66e..2356d621967e 100644
> --- a/drivers/misc/pvpanic.c
> +++ b/drivers/misc/pvpanic.c
> @@ -92,6 +92,7 @@ static const struct of_device_id pvpanic_mmio_match[] = {
> { .compatible = "qemu,pvpanic-mmio", },
> {}
> };
> +MODULE_DEVICE_TABLE(of, pvpanic_mmio_match);
What caused this to not work properly? I.e. should there be a "Fixes:"
tag in the commit changelog as well?
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-18 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 9:40 [PATCH] misc/pvpanic: Export module FDT device table Shile Zhang
2021-02-18 10:00 ` Greg Kroah-Hartman [this message]
2021-02-18 10:51 ` Shile Zhang
2021-02-18 12:21 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC46tZLAesfSNg40@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=shile.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.