From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B53FC433DB for ; Thu, 18 Feb 2021 12:16:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18D3164E2F for ; Thu, 18 Feb 2021 12:16:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231549AbhBRMPy (ORCPT ); Thu, 18 Feb 2021 07:15:54 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]:35734 "EHLO mail-qt1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231633AbhBRL5n (ORCPT ); Thu, 18 Feb 2021 06:57:43 -0500 Received: by mail-qt1-f179.google.com with SMTP id g24so1136867qts.2; Thu, 18 Feb 2021 03:55:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2kEv8sIFU+zpk6Mq8W5TYFeq6VABHf9B9emGrVNqUxw=; b=P5Cq27fWBFe56Jgi5mVg4WDyYBWU5CS6aXI5sEIoLRJhM5N1yM9s1ZZyyu1dKnm+ZF FPdG/H6PJ+kfU2GigYgBhk//vQJmXrkaOVA99hfyxvhKt1Xdnn11zIje1m27xOK41C2L CIqbAfrRpp+4pVop3C6m6IxIj1whsqp12kV4ZY7wQhqsswuff+FH+fkSNr4dwWzh3SfO lPnKV4DzNy1E1CcYi2F6IrgM6S6yre6yBbG9PKlV6WAJe3GXrtMe+AvFl/sALC+W2y/A 4CbLWq8mp4JqpzHjV8oSekPEx0XNcuH3yH/kXZC4zxsVWG/nU9hbjLGhdCpZtEhTwmWv 1zfg== X-Gm-Message-State: AOAM533R+rIFFLRpt9IbqfY7FT6TJzJHtqlM3bNvkP9fxqSSWVXvaEZ1 lqN4H6xJGJw+h2B5Kuc7HMM= X-Google-Smtp-Source: ABdhPJwq4o+OkO9IbuRkPF2GzLzPv1GdXZmEb2PU7uYq1lEm+iWIvWB4fZ/UW01rHB9BLj9o4u3yuA== X-Received: by 2002:a05:622a:28b:: with SMTP id z11mr3735807qtw.225.1613649309429; Thu, 18 Feb 2021 03:55:09 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id 16sm3001512qtp.38.2021.02.18.03.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 03:55:09 -0800 (PST) Date: Thu, 18 Feb 2021 12:55:05 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Richard Zhu Cc: l.stach@pengutronix.de, helgaas@kernel.org, stefan@agner.ch, lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie Message-ID: References: <1613624980-29382-1-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1613624980-29382-1-git-send-email-hongxing.zhu@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Richard, Thank you for sending the patch over! > Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"), > i.MX6QP PCIe has the similar issue. > Define the length of the DBI registers and limit config space to its > length for i.MX6QP PCIe too. You could probably flip these two sentences around to make the commit message read slightly better, so what about this (a suggestion): Define the length of the DBI registers and limit config space to its length. This makes sure that the kernel does not access registers beyond that point that otherwise would lead to an abort on a i.MX 6QuadPlus. See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that resolves a similar issue on a i.MX 6Quad PCIe. > Signed-off-by: Richard Zhu > --- > drivers/pci/controller/dwc/pci-imx6.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 0cf1333c0440..853ea8e82952 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1175,6 +1175,7 @@ static const struct imx6_pcie_drvdata drvdata[] = { > .variant = IMX6QP, > .flags = IMX6_PCIE_FLAG_IMX6_PHY | > IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > + .dbi_length = 0x200, > }, > [IMX7D] = { > .variant = IMX7D, Reviewed-by: Krzysztof Wilczyński Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE896C433E0 for ; Thu, 18 Feb 2021 11:57:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52F0864D79 for ; Thu, 18 Feb 2021 11:57:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52F0864D79 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O9Wsn2FerDRe2j6misjDlPrAd3Y0q639VMipNDgUycg=; b=yDXaj2fAi9BfZVa63FtmEBuMO fisj9QoNiCHXfSCz8gKPyJPs8mfp3JMSpPI1BUk4Hcoptul05J1H3yu8YtR64/K3iQtAp1Q2krHOw AOe8dj5Egqri6MBBIVOCmRFIjii6brhbgsrlkW3r2sd/98jeLgczQqVIKbeusSK9KyzCDNAbjdG9P SczewlawYqr5PqRBY01u4rDt4rT7ypXNYTK2OfRyvdcVUGcr5g5yye8LOPCwi7IQKZni9X3mVMzDV UehVvWPFbWuqGgHY09/lPc+vcPZq67nUXh33wW86QUQaN7Zsae3prPyVF05CG6jkTRqYFHaxbH/T4 1CgPnd1kQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lChtq-0002To-If; Thu, 18 Feb 2021 11:55:14 +0000 Received: from mail-qt1-f171.google.com ([209.85.160.171]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lChto-0002TF-37 for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 11:55:13 +0000 Received: by mail-qt1-f171.google.com with SMTP id f17so1114361qth.7 for ; Thu, 18 Feb 2021 03:55:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2kEv8sIFU+zpk6Mq8W5TYFeq6VABHf9B9emGrVNqUxw=; b=g6daO4JLKIg2lSuTOY6kknx+8b7WCSsjVyd+wmnYUc3senPp3y8y6B0jlqMzMcaHCT orMftD5XmRorZwj4BCzYAf8qvJ1lkMP5NF/H82XBd0leEmpmkC4e7EWgfmqtrwa3zzEp mjAW9mIpuCPpNNsg+Nvow5BiLTh/o/jgt2vjhymlC1jsKCfW2ZHunHW9MA6kdMk6Y2Xx PFyhCr7gi6mL6VmxC2BbwdRerJ7JWdYemb+fkPVCqRRDC4rZ5paXWy3tnYJISVTpVYJo tq6LrPnfhRAwkpCtFLjn3pnkstSzUuH/41+B4PNKh01j0YN0wBro38Jd9+it2nDJV8zr gwDw== X-Gm-Message-State: AOAM530I4bRwVrfPPVrMMeUMxlTAa/Go0v/Z1fJcqo5APfcUUWknxjuf t6EfXaMvfLjAGYKKHGaLvtjUS3//vqA= X-Google-Smtp-Source: ABdhPJwq4o+OkO9IbuRkPF2GzLzPv1GdXZmEb2PU7uYq1lEm+iWIvWB4fZ/UW01rHB9BLj9o4u3yuA== X-Received: by 2002:a05:622a:28b:: with SMTP id z11mr3735807qtw.225.1613649309429; Thu, 18 Feb 2021 03:55:09 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id 16sm3001512qtp.38.2021.02.18.03.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 03:55:09 -0800 (PST) Date: Thu, 18 Feb 2021 12:55:05 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Richard Zhu Subject: Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie Message-ID: References: <1613624980-29382-1-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1613624980-29382-1-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_065512_154510_0FAAFD6A X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, stefan@agner.ch, helgaas@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUmljaGFyZCwKClRoYW5rIHlvdSBmb3Igc2VuZGluZyB0aGUgcGF0Y2ggb3ZlciEKCj4gUmVm ZXIgdG8gY29tbWl0IDA3NWFmNjFjMTljZCAoIlBDSTogaW14NjogTGltaXQgREJJIHJlZ2lzdGVy IGxlbmd0aCIpLAo+IGkuTVg2UVAgUENJZSBoYXMgdGhlIHNpbWlsYXIgaXNzdWUuCj4gRGVmaW5l IHRoZSBsZW5ndGggb2YgdGhlIERCSSByZWdpc3RlcnMgYW5kIGxpbWl0IGNvbmZpZyBzcGFjZSB0 byBpdHMKPiBsZW5ndGggZm9yIGkuTVg2UVAgUENJZSB0b28uCgpZb3UgY291bGQgcHJvYmFibHkg ZmxpcCB0aGVzZSB0d28gc2VudGVuY2VzIGFyb3VuZCB0byBtYWtlIHRoZSBjb21taXQKbWVzc2Fn ZSByZWFkIHNsaWdodGx5IGJldHRlciwgc28gd2hhdCBhYm91dCB0aGlzIChhIHN1Z2dlc3Rpb24p OgoKRGVmaW5lIHRoZSBsZW5ndGggb2YgdGhlIERCSSByZWdpc3RlcnMgYW5kIGxpbWl0IGNvbmZp ZyBzcGFjZSB0byBpdHMKbGVuZ3RoLiBUaGlzIG1ha2VzIHN1cmUgdGhhdCB0aGUga2VybmVsIGRv ZXMgbm90IGFjY2VzcyByZWdpc3RlcnMgYmV5b25kCnRoYXQgcG9pbnQgdGhhdCBvdGhlcndpc2Ug d291bGQgbGVhZCB0byBhbiBhYm9ydCBvbiBhIGkuTVggNlF1YWRQbHVzLgoKU2VlIGNvbW1pdCAw NzVhZjYxYzE5Y2QgKCJQQ0k6IGlteDY6IExpbWl0IERCSSByZWdpc3RlciBsZW5ndGgiKSB0aGF0 CnJlc29sdmVzIGEgc2ltaWxhciBpc3N1ZSBvbiBhIGkuTVggNlF1YWQgUENJZS4KCj4gU2lnbmVk LW9mZi1ieTogUmljaGFyZCBaaHUgPGhvbmd4aW5nLnpodUBueHAuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jIHwgMSArCj4gIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2ktaW14Ni5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWlteDYuYwo+ IGluZGV4IDBjZjEzMzNjMDQ0MC4uODUzZWE4ZTgyOTUyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv cGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMKPiArKysgYi9kcml2ZXJzL3BjaS9jb250cm9s bGVyL2R3Yy9wY2ktaW14Ni5jCj4gQEAgLTExNzUsNiArMTE3NSw3IEBAIHN0YXRpYyBjb25zdCBz dHJ1Y3QgaW14Nl9wY2llX2RydmRhdGEgZHJ2ZGF0YVtdID0gewo+ICAJCS52YXJpYW50ID0gSU1Y NlFQLAo+ICAJCS5mbGFncyA9IElNWDZfUENJRV9GTEFHX0lNWDZfUEhZIHwKPiAgCQkJIElNWDZf UENJRV9GTEFHX0lNWDZfU1BFRURfQ0hBTkdFLAo+ICsJCS5kYmlfbGVuZ3RoID0gMHgyMDAsCj4g IAl9LAo+ICAJW0lNWDdEXSA9IHsKPiAgCQkudmFyaWFudCA9IElNWDdELAoKUmV2aWV3ZWQtYnk6 IEtyenlzenRvZiBXaWxjennFhHNraSA8a3dAbGludXguY29tPgoKS3J6eXN6dG9mCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==