From: Johannes Weiner <hannes@cmpxchg.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Michal Hocko <mhocko@suse.com>,
Roman Gushchin <guro@fb.com>, Shakeel Butt <shakeelb@google.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v3 4/8] cgroup: rstat: support cgroup1
Date: Thu, 18 Feb 2021 12:06:42 -0500 [thread overview]
Message-ID: <YC6eojaku6oaOqA2@cmpxchg.org> (raw)
In-Reply-To: <YC6Lh8BRfMA2Ppdk@blackbook>
On Thu, Feb 18, 2021 at 04:45:11PM +0100, Michal Koutný wrote:
> On Wed, Feb 17, 2021 at 03:52:59PM -0500, Johannes Weiner <hannes@cmpxchg.org> wrote:
> > In this case, we're talking about a relatively small data structure
> > and the overhead is per mountpoint.
> IIUC, it is per each mountpoint's number of cgroups. But I still accept
> the argument above. Furthermore, this can be changed later.
Oops, you're right of course.
> > The default root group has statically preallocated percpu data before
> > and after this patch. See cgroup.c:
> I stand corrected, the comment is still valid.
>
> Therefore,
> Reviewed-by: Michal Koutný <mkoutny@suse.com>
Thanks for your reviews, Michal!
next prev parent reply other threads:[~2021-02-18 17:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 16:32 [PATCH v3 0/8] mm: memcontrol: switch to rstat Johannes Weiner
2021-02-09 16:32 ` Johannes Weiner
[not found] ` <20210209163304.77088-1-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-09 16:32 ` [PATCH v3 1/8] mm: memcontrol: fix cpuhotplug statistics flushing Johannes Weiner
2021-02-09 16:32 ` Johannes Weiner
[not found] ` <20210209163304.77088-2-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-17 17:43 ` Michal Koutný
2021-02-17 17:43 ` Michal Koutný
2021-02-09 16:32 ` [PATCH v3 2/8] mm: memcontrol: kill mem_cgroup_nodeinfo() Johannes Weiner
2021-02-09 16:32 ` Johannes Weiner
[not found] ` <20210209163304.77088-3-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-17 17:43 ` Michal Koutný
2021-02-17 17:43 ` Michal Koutný
2021-02-09 16:32 ` [PATCH v3 3/8] mm: memcontrol: privatize memcg_page_state query functions Johannes Weiner
2021-02-09 16:32 ` Johannes Weiner
[not found] ` <20210209163304.77088-4-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-17 17:44 ` Michal Koutný
2021-02-17 17:44 ` Michal Koutný
2021-02-09 16:33 ` [PATCH v3 4/8] cgroup: rstat: support cgroup1 Johannes Weiner
2021-02-09 16:33 ` Johannes Weiner
[not found] ` <20210209163304.77088-5-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-17 17:42 ` Michal Koutný
2021-02-17 17:42 ` Michal Koutný
2021-02-17 20:52 ` Johannes Weiner
[not found] ` <YC2CKyaeF2bqvpMk-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-18 15:45 ` Michal Koutný
2021-02-18 15:45 ` Michal Koutný
2021-02-18 17:06 ` Johannes Weiner [this message]
2021-02-09 16:33 ` [PATCH v3 5/8] cgroup: rstat: punt root-level optimization to individual controllers Johannes Weiner
2021-02-09 16:33 ` Johannes Weiner
2021-02-09 16:33 ` [PATCH v3 6/8] mm: memcontrol: switch to rstat Johannes Weiner
2021-02-09 16:33 ` Johannes Weiner
[not found] ` <20210209163304.77088-7-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-18 15:36 ` Michal Koutný
2021-02-18 15:36 ` Michal Koutný
2021-02-09 16:33 ` [PATCH v3 7/8] mm: memcontrol: consolidate lruvec stat flushing Johannes Weiner
2021-02-09 16:33 ` Johannes Weiner
[not found] ` <20210209163304.77088-8-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-09 20:21 ` Roman Gushchin
2021-02-09 20:21 ` Roman Gushchin
2021-02-09 16:33 ` [PATCH v3 8/8] kselftests: cgroup: update kmem test for new vmstat implementation Johannes Weiner
[not found] ` <20210209163304.77088-9-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-02-09 20:17 ` Roman Gushchin
2021-02-09 20:17 ` Roman Gushchin
2021-02-18 15:37 ` Michal Koutný
2021-02-18 15:37 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC6eojaku6oaOqA2@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mkoutny@suse.com \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.