From: Greg KH <gregkh@linuxfoundation.org>
To: "Schmid, Carsten" <Carsten_Schmid@mentor.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"weiwan@google.com" <weiwan@google.com>,
"idosch@idosch.org" <idosch@idosch.org>,
"jesse@mbuki-mvuki.org" <jesse@mbuki-mvuki.org>,
"kafai@fb.com" <kafai@fb.com>,
"dsahern@gmail.com" <dsahern@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: Where is this patch buried?
Date: Mon, 8 Feb 2021 10:48:40 +0100 [thread overview]
Message-ID: <YCEI+GYwWLhKQURS@kroah.com> (raw)
In-Reply-To: <1612776251858.30522@mentor.com>
On Mon, Feb 08, 2021 at 09:24:11AM +0000, Schmid, Carsten wrote:
> >> Hi Greg,
> >>
> >> in kernel 4.14 i have seen a NULL pointer deref in
> >> [65064.613465] RIP: 0010:ip_route_output_key_hash_rcu+0x755/0x850
> >> (i have a core dump and detailed analysis)
> >>
> >> That looks like this patch could have prevented it:
> >>
> >> https://www.spinics.net/lists/stable-commits/msg133055.html
> >>
> >> this one was queued for 4.14, but i can't find it in git tree?
> >> Any idea who/what buried this one?
> >>
> >> In 4.19 it is present.
> >>
> >> Because our customer uses 4.14 (going to 4.14.212 in a few days) i kindly want to
> >> ask why this patch hasn't entered 4.14.
> >
> > Because it breaks the build? Try it yourself and see what happens :)
>
> yep. rt_add_uncached_list is implemented _after_ the call :-(
>
> >
> > I will gladly take a working backport if you can submit it.
> >
> Please find it attached - i needed to move rt_add_uncached_list before
> the rt_cache_route, nothing else changed.
> This is for 4.14 only, as other kernels do have this patch.
>
> I can't reproduce the crash at will, but at least i could compile and flash it on my target.
> And the target comes up .. hopefully the testing in other/newer kernels
> done by the developers of the patch is also valid for 4.14.
Thanks, now queued up.
greg k-h
prev parent reply other threads:[~2021-02-08 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 8:12 Where is this patch buried? Schmid, Carsten
2021-02-08 8:49 ` Greg KH
2021-02-08 9:24 ` AW: " Schmid, Carsten
2021-02-08 9:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCEI+GYwWLhKQURS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Carsten_Schmid@mentor.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@idosch.org \
--cc=jesse@mbuki-mvuki.org \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.