From: Greg KH <gregkh@linuxfoundation.org>
To: Mukul Mehar <mukulmehar02@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: checkpatch: Fixed styling issue
Date: Mon, 8 Feb 2021 20:58:37 +0100 [thread overview]
Message-ID: <YCGX7Yj90jwQYh0L@kroah.com> (raw)
In-Reply-To: <20210208195116.GA19781@gmail.com>
On Tue, Feb 09, 2021 at 01:21:16AM +0530, Mukul Mehar wrote:
> >From 29bcaf0066003983da29b1e026b985c0727b091a Mon Sep 17 00:00:00 2001
> From: Mukul Mehar <mukulmehar02@gmail.com>
> Date: Mon, 8 Feb 2021 01:03:06 +0530
> Subject: [PATCH] Drivers: staging: most: sound: Fixed style issue.
>
> This patch fixes a warning, of the line ending with a '(',
> generated by checkpatch.pl.
> This is my first patch.
>
> Signed-off-by: Mukul Mehar <mukulmehar02@gmail.com>
> ---
> drivers/staging/most/sound/sound.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
> index 3a1a59058042..4dd1bf95d1ce 100644
> --- a/drivers/staging/most/sound/sound.c
> +++ b/drivers/staging/most/sound/sound.c
> @@ -228,12 +228,12 @@ static int playback_thread(void *data)
> struct mbo *mbo = NULL;
> bool period_elapsed = false;
>
> - wait_event_interruptible(
> - channel->playback_waitq,
> - kthread_should_stop() ||
> - (channel->is_stream_running &&
> - (mbo = most_get_mbo(channel->iface, channel->id,
> - &comp))));
> + wait_event_interruptible(channel->playback_waitq,
> + kthread_should_stop() ||
> + (channel->is_stream_running &&
> + (mbo = most_get_mbo(channel->iface,
> + channel->id,
> + &comp))));
> if (!mbo)
> continue;
>
> --
> 2.25.1
Again, all of the things that my bot found last time are still relevant
here. Please fix them all.
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-08 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 19:51 [PATCH]: checkpatch: Fixed styling issue Mukul Mehar
2021-02-08 19:58 ` Greg KH [this message]
2021-02-08 21:21 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2021-02-08 18:28 Mukul Mehar
2021-02-08 18:33 ` Greg KH
2021-02-08 13:06 Mukul Mehar
2021-02-08 13:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCGX7Yj90jwQYh0L@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mukulmehar02@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.