All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsck: fix check of directories over 4GB
Date: Mon, 8 Feb 2021 23:23:29 -0500	[thread overview]
Message-ID: <YCIOQSLElpGk9rKX@mit.edu> (raw)
In-Reply-To: <20210202082549.2936-1-adilger@whamcloud.com>

On Tue, Feb 02, 2021 at 01:25:49AM -0700, Andreas Dilger wrote:
> If directories grow larger than 4GB in size with the large_dir
> feature, e2fsck will consider them to be corrupted and clear
> the high bits of the size.
> 
> Since it isn't very common to have directories this large, and
> unlike sparse files that don't have ill effects if the size is
> too large, an too-large directory will have all of the sparse
> blocks filled in by e2fsck, so huge directories should still
> be viewed with suspicion.  Check for consistency between two of
> the three among block count, inode size, and superblock large_dir
> flag before deciding whether the directory inode should be fixed
> or cleared, or if large_dir should be set in the superblock.
> 
> Update the f_recnect_bad test case to match new output.
> 
> Fixes: 49f28a06b738 ("e2fsck: allow to check >2GB sized directory")
> Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
> Lustre-bug-id: https://jira.whamcloud.com/browse/LU-14345
> Change-Id: I1b898cdab95d239ba1a7b37eb96255acadce7057

Thanks, applied.

						- Ted

      reply	other threads:[~2021-02-09  4:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02  8:25 [PATCH] e2fsck: fix check of directories over 4GB Andreas Dilger
2021-02-09  4:23 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCIOQSLElpGk9rKX@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger@whamcloud.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.