All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] if-mtu-change.sh: Lower CHANGE_INTERVAL for netns
Date: Tue, 9 Feb 2021 15:12:22 +0100	[thread overview]
Message-ID: <YCKYRhZzAQ3VVKzk@pevik> (raw)
In-Reply-To: <45f388a1-4c96-d35c-8c61-879631fcae51@oracle.com>

Hi Alexey,

> On 08.02.2021 19:04, Petr Vorel wrote:
> > How about allow to overwrite CHANGE_INTERVAL even for netns?
> > i.e move tst_is_int $CHANGE_INTERVAL && TST_TIMEOUT=$CHANGE_INTERVAL
> > after the test (although it's unlikely anybody would use sec value for netns
> > and ms value for ssh):

> > # CHANGE_INTERVAL: The interval of the mtu change
> > TST_TIMEOUT=1
> > if tst_net_use_netns; then
> >     CHANGE_INTERVAL=${CHANGE_INTERVAL:-100ms}
> > else
> >     CHANGE_INTERVAL=${CHANGE_INTERVAL:-5}
> > fi
> > tst_is_int $CHANGE_INTERVAL && TST_TIMEOUT=$CHANGE_INTERVAL
> > TST_TIMEOUT=$(((TST_TIMEOUT + 30) * MTU_CHANGE_TIMES))


> Yeah, looks good.
Thanks for your ack, merged!

Kind regards,
Petr

      reply	other threads:[~2021-02-09 14:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 14:20 [LTP] [PATCH 1/2] tst_net.sh: Add API function to check netns use Petr Vorel
2021-02-05 14:20 ` [LTP] [PATCH 2/2] if-mtu-change.sh: Lower CHANGE_INTERVAL for netns Petr Vorel
2021-02-08 12:49   ` Alexey Kodanev
2021-02-08 16:04     ` Petr Vorel
2021-02-09 12:45       ` Alexey Kodanev
2021-02-09 14:12         ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCKYRhZzAQ3VVKzk@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.