From: Jiri Olsa <jolsa@redhat.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Veronika Kabatova <vkabatov@redhat.com>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM
Date: Tue, 9 Feb 2021 17:13:38 +0100 [thread overview]
Message-ID: <YCKwxNDkS9rdr43W@krava> (raw)
In-Reply-To: <YCKlrLkTQXc4Cyx7@krava>
On Tue, Feb 09, 2021 at 04:09:36PM +0100, Jiri Olsa wrote:
SNIP
> > > > > DW_AT_prototyped (true)
> > > > > DW_AT_type (0x01cfdfe4 "long int")
> > > > > DW_AT_external (true)
> > > > >
> > > >
> > > > Ok, the problem appears to be not in DWARF, but in mcount_loc data.
> > > > vfs_truncate's address is not recorded as ftrace-attachable, and thus
> > > > pahole ignores it. I don't know why this happens and it's quite
> > > > strange, given vfs_truncate is just a normal global function.
> >
> > right, I can't see it in mcount adresses.. but it begins with instructions
> > that appears to be nops, which would suggest it's traceable
> >
> > ffff80001031f430 <vfs_truncate>:
> > ffff80001031f430: 5f 24 03 d5 hint #34
> > ffff80001031f434: 1f 20 03 d5 nop
> > ffff80001031f438: 1f 20 03 d5 nop
> > ffff80001031f43c: 3f 23 03 d5 hint #25
> >
> > > >
> > > > I'd like to understand this issue before we try to fix it, but there
> > > > is at least one improvement we can make: pahole should check ftrace
> > > > addresses only for static functions, not the global ones (global ones
> > > > should be always attachable, unless they are special, e.g., notrace
> > > > and stuff). We can easily check that by looking at the corresponding
> > > > symbol. But I'd like to verify that vfs_truncate is ftrace-attachable
>
> I'm still trying to build the kernel.. however ;-)
I finally reproduced.. however arm's not using mcount_loc
but some other special section.. so it's new mess for me
however I tried the same build without LLVM=1 and it passed,
so my guess is that clang is doing something unexpected
jirka
next prev parent reply other threads:[~2021-02-09 16:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 3:44 FAILED unresolved symbol vfs_truncate on arm64 with LLVM Nathan Chancellor
2021-02-09 4:45 ` Andrii Nakryiko
2021-02-09 5:23 ` Nathan Chancellor
2021-02-09 6:09 ` Andrii Nakryiko
2021-02-09 6:13 ` Andrii Nakryiko
2021-02-09 6:56 ` Andrii Nakryiko
2021-02-09 7:49 ` Nathan Chancellor
2021-02-09 12:36 ` Jiri Olsa
2021-02-09 15:09 ` Jiri Olsa
2021-02-09 16:13 ` Jiri Olsa [this message]
2021-02-09 16:35 ` Nathan Chancellor
2021-02-09 17:07 ` Sedat Dilek
2021-02-09 17:12 ` Nick Desaulniers
2021-02-09 17:26 ` Sedat Dilek
2021-02-09 19:06 ` Jiri Olsa
2021-02-09 19:22 ` Jiri Olsa
2021-02-09 20:09 ` Nick Desaulniers
2021-02-09 20:50 ` Jiri Olsa
2021-02-09 21:41 ` Jiri Olsa
2021-02-09 23:15 ` Nathan Chancellor
2021-02-10 0:02 ` Nathan Chancellor
2021-02-10 0:49 ` Daniel Kiss
2021-02-10 11:34 ` David Laight
2021-02-10 12:32 ` Jiri Olsa
2021-02-09 20:59 ` Andrii Nakryiko
2021-02-09 21:55 ` Jiri Olsa
2021-02-09 22:00 ` Andrii Nakryiko
2021-02-10 13:26 ` Jiri Olsa
2021-02-10 18:02 ` Nathan Chancellor
2021-02-10 18:20 ` Andrii Nakryiko
2021-02-10 18:24 ` Sedat Dilek
2021-02-10 19:10 ` Jiri Olsa
2021-02-10 19:21 ` Andrii Nakryiko
2021-02-10 20:13 ` Jiri Olsa
2021-02-11 15:08 ` Jiri Olsa
2021-02-11 15:43 ` Sedat Dilek
2021-02-11 16:07 ` Jiri Olsa
2021-02-11 16:36 ` Sedat Dilek
2021-02-11 17:24 ` Nathan Chancellor
2021-02-11 19:59 ` Andrii Nakryiko
2021-02-11 21:47 ` Jiri Olsa
2021-02-12 16:38 ` Jiri Olsa
2021-02-12 19:22 ` Andrii Nakryiko
2021-02-12 21:29 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCKwxNDkS9rdr43W@krava \
--to=jolsa@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=vkabatov@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.