From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH stable 4.9] mm: memcontrol: fix NULL pointer crash in test_clear_page_writeback() Date: Tue, 9 Feb 2021 16:19:46 -0500 Message-ID: References: <20210209202616.2257512-1-f.fainelli@gmail.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=E+GwgIRGKbJyN6BMx9osGrabexMLPqEhC8h9yJvwcPI=; b=qVg6eWt/p+mtaLHMJ3UMS3pa7cP8tRdSZltmlPVvywtYM1Xz2GgR7lvaILGqsvNc5q vYrdlEDpJ6LAExkiYJ+B2vgDJ4ic2ZFx3wDChTDEaZfGBOTtJtLCbFQKoE4/Vk9+CRMe /MncFu/kd8cMm7K8t7NNOuyjR2eP2G5CTovSmA03FmKDfH7k80wPNw51QigLDkuqVVoO 9Jsosv3nlBPAAyWAq3Pt67mVcQfjR5jY5YDPEDWGyqd4Kp1yax1q4OadysJ422FdpCbt WX/JTNoTftwxDefcRi52Porkf9IdP/D/O6sbzPHti4g2tYZ9YwaiO2XPK1xOKsZWKK6h TUWw== Content-Disposition: inline In-Reply-To: <20210209202616.2257512-1-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Florian Fainelli Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jaegeuk Kim , Bradley Bolen , Vladimir Davydov , Michal Hocko , Andrew Morton , Linus Torvalds , Prakash Gupta , Michal Hocko , Vladimir Davydov , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" On Tue, Feb 09, 2021 at 12:26:15PM -0800, Florian Fainelli wrote: > From: Johannes Weiner > > commit 739f79fc9db1b38f96b5a5109b247a650fbebf6d upstream ... > This patch is present in a downstream Android tree: > > https://source.mcwhirter.io/craige/bluecross/commit/d4a742865c6b69ef931694745ef54965d7c9966c > > and I happened to have stumbled across the same problem too. > > Johannes can you review it for correctness with respect to the 4.9 > kernel? Thanks! Looks good to me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7859EC433DB for ; Tue, 9 Feb 2021 21:19:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D61DA64DAF for ; Tue, 9 Feb 2021 21:19:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D61DA64DAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F08B26B0005; Tue, 9 Feb 2021 16:19:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB9DB6B006C; Tue, 9 Feb 2021 16:19:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD5D56B006E; Tue, 9 Feb 2021 16:19:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id C46756B0005 for ; Tue, 9 Feb 2021 16:19:49 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 880A110F6E for ; Tue, 9 Feb 2021 21:19:49 +0000 (UTC) X-FDA: 77799996498.17.name75_2104af52760a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 652C4185B95F2 for ; Tue, 9 Feb 2021 21:19:49 +0000 (UTC) X-HE-Tag: name75_2104af52760a X-Filterd-Recvd-Size: 4016 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 21:19:48 +0000 (UTC) Received: by mail-qv1-f44.google.com with SMTP id j13so9397119qvu.10 for ; Tue, 09 Feb 2021 13:19:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=E+GwgIRGKbJyN6BMx9osGrabexMLPqEhC8h9yJvwcPI=; b=qVg6eWt/p+mtaLHMJ3UMS3pa7cP8tRdSZltmlPVvywtYM1Xz2GgR7lvaILGqsvNc5q vYrdlEDpJ6LAExkiYJ+B2vgDJ4ic2ZFx3wDChTDEaZfGBOTtJtLCbFQKoE4/Vk9+CRMe /MncFu/kd8cMm7K8t7NNOuyjR2eP2G5CTovSmA03FmKDfH7k80wPNw51QigLDkuqVVoO 9Jsosv3nlBPAAyWAq3Pt67mVcQfjR5jY5YDPEDWGyqd4Kp1yax1q4OadysJ422FdpCbt WX/JTNoTftwxDefcRi52Porkf9IdP/D/O6sbzPHti4g2tYZ9YwaiO2XPK1xOKsZWKK6h TUWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E+GwgIRGKbJyN6BMx9osGrabexMLPqEhC8h9yJvwcPI=; b=qzueapQI1hj6b2NY8GOpOookL8nkH+g0NdMJ/JGR5LiT49T7o7KM4ko4bMHrpbPXz7 2NS2qLMN9IUObS+mmyR9pttl0fJUN5iMKrTv7Ar3bup4V9wuOR6DYbKhyvhtAgPVEAG0 ecyCUQfZ+cGRBeR/0k8wZjovJ6rWTW05sNgQb/KvgNtGiQbwEehVW0IaTCQNXRlYPTp2 RBZGM16glxXBXVC6dUXIYi6KXTHtA4MWIjnsNTFRI0dr7hfftsC8Iw3w4+S7OLCWM2iU 95fxY4qfVRp7CT7obAGjK84v4SVF7ewHJ6jZxrmcmLga1ZDMu5RYy/viGm1mUPgmcE8V XZIA== X-Gm-Message-State: AOAM532cp8+mCvEKWecOUXAK8x9SOW3LBHa0ghvYZtCXf5eCjB9ly2o2 ZPYXa1jXqInJof+9+5lfcjcpkA== X-Google-Smtp-Source: ABdhPJzC1y781rKFs2oJ/EMXGnR/H0Bxxy1Ep70Zk8iEdT2DuGjbTeRKP6O9dCSwmHzW9pi7dRURgA== X-Received: by 2002:a05:6214:1643:: with SMTP id f3mr122351qvw.4.1612905588033; Tue, 09 Feb 2021 13:19:48 -0800 (PST) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id 199sm20696467qkm.126.2021.02.09.13.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 13:19:47 -0800 (PST) Date: Tue, 9 Feb 2021 16:19:46 -0500 From: Johannes Weiner To: Florian Fainelli Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Jaegeuk Kim , Bradley Bolen , Vladimir Davydov , Michal Hocko , Andrew Morton , Linus Torvalds , Prakash Gupta , Michal Hocko , Vladimir Davydov , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" Subject: Re: [PATCH stable 4.9] mm: memcontrol: fix NULL pointer crash in test_clear_page_writeback() Message-ID: References: <20210209202616.2257512-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209202616.2257512-1-f.fainelli@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 09, 2021 at 12:26:15PM -0800, Florian Fainelli wrote: > From: Johannes Weiner > > commit 739f79fc9db1b38f96b5a5109b247a650fbebf6d upstream ... > This patch is present in a downstream Android tree: > > https://source.mcwhirter.io/craige/bluecross/commit/d4a742865c6b69ef931694745ef54965d7c9966c > > and I happened to have stumbled across the same problem too. > > Johannes can you review it for correctness with respect to the 4.9 > kernel? Thanks! Looks good to me.