From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next] net: phy: introduce phydev->port
Date: Wed, 10 Feb 2021 02:53:30 +0100 [thread overview]
Message-ID: <YCM8mu6OSIsSz9TI@lunn.ch> (raw)
In-Reply-To: <20210209163852.17037-1-michael@walle.cc>
On Tue, Feb 09, 2021 at 05:38:52PM +0100, Michael Walle wrote:
> At the moment, PORT_MII is reported in the ethtool ops. This is odd
> because it is an interface between the MAC and the PHY and no external
> port. Some network card drivers will overwrite the port to twisted pair
> or fiber, though. Even worse, the MDI/MDIX setting is only used by
> ethtool if the port is twisted pair.
>
> Set the port to PORT_TP by default because most PHY drivers are copper
> ones. If there is fibre support and it is enabled, the PHY driver will
> set it to PORT_FIBRE.
>
> This will change reporting PORT_MII to either PORT_TP or PORT_FIBRE;
> except for the genphy fallback driver.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-02-10 2:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 16:38 [PATCH net-next] net: phy: introduce phydev->port Michael Walle
2021-02-09 23:01 ` Florian Fainelli
2021-02-10 1:51 ` Andrew Lunn
2021-02-10 11:01 ` Russell King - ARM Linux admin
2021-02-10 1:53 ` Andrew Lunn [this message]
2021-02-10 11:20 ` Michael Walle
2021-02-10 11:54 ` Russell King - ARM Linux admin
2021-02-10 12:10 ` Michael Walle
2021-02-10 18:34 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCM8mu6OSIsSz9TI@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.