Re: [PATCH v3 1/4] arm64: dts: qcom: sm8250: split spi pinctrl config

[Bjorn Andersson <bjorn.andersson@linaro.org>]

On Tue 09 Feb 17:57 CST 2021, Doug Anderson wrote:

> Hi,
> 
> On Tue, Feb 9, 2021 at 12:29 PM Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
> >
> > As discussed on linux-arm-msm list, start splitting sm8250 pinctrl
> > settings into generic and board-specific parts. The first part to
> > receive such treatment is the spi, so split spi pinconf to the board
> > device tree.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/qrb5165-rb5.dts |   5 +
> >  arch/arm64/boot/dts/qcom/sm8250.dtsi     | 300 +++++------------------
> >  2 files changed, 65 insertions(+), 240 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> > index 2f0528d01299..787da8ccba54 100644
> > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> > @@ -815,6 +815,11 @@ &pm8150_rtc {
> >         status = "okay";
> >  };
> >
> > +&qup_spi0_default {
> > +       drive-strength = <6>;
> > +       bias-disable;
> > +};
> > +
> 
> Optional nit that I personally prefer that all of the pinctrl stuff be
> grouped together (with separate sorting) at the bottom of board device
> tree files.  To me it's weird to mix them with peripheral enables.
> 

I share this preference, but let's figure out how to document these
"guidelines" and take that as a separate change.

Regards,
Bjorn

> Reviewed-by: Douglas Anderson <dianders@chromium.org>