From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Wed, 10 Feb 2021 13:12:37 +0000 Subject: Re: [PATCH] video: use getter/setter functions Message-Id: List-Id: References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> <20210210082341.GH220368@dell> In-Reply-To: <20210210082341.GH220368@dell> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Lee Jones Cc: Daniel Thompson , linux-omap@vger.kernel.org, Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Simek , Julia Lawall , linux-fbdev@vger.kernel.org, Andy Gross , NXP Linux Team , Pengutronix Kernel Team , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Shawn Guo , linux-arm-kernel@lists.infradead.org On Wed, Feb 10, 2021 at 08:23:41AM +0000, Lee Jones wrote: > On Tue, 09 Feb 2021, Julia Lawall wrote: > > > Use getter and setter functions, for platform_device structures and a > > spi_device structure. > > > > Signed-off-by: Julia Lawall > > > > --- > > drivers/video/backlight/qcom-wled.c | 2 +- > > This patch is fine. > > Could you please split it out and submit it separately though please. Or just apply the entire patch through backlight tree, there's nothing going on in fbdev anyway I think. Acked-by: Daniel Vetter > > > drivers/video/fbdev/amifb.c | 4 ++-- > > drivers/video/fbdev/da8xx-fb.c | 4 ++-- > > drivers/video/fbdev/imxfb.c | 2 +- > > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 6 +++--- > > drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 4 ++-- > > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++-- > > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 2 +- > > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 2 +- > > drivers/video/fbdev/xilinxfb.c | 2 +- > > 10 files changed, 16 insertions(+), 16 deletions(-) > > ...] > > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > > index 3bc7800eb0a9..091f07e7c145 100644 > > --- a/drivers/video/backlight/qcom-wled.c > > +++ b/drivers/video/backlight/qcom-wled.c > > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev) > > > > static int wled_remove(struct platform_device *pdev) > > { > > - struct wled *wled = dev_get_drvdata(&pdev->dev); > > + struct wled *wled = platform_get_drvdata(pdev); > > > > mutex_destroy(&wled->lock); > > cancel_delayed_work_sync(&wled->ovp_work); > > For my own reference (apply this as-is to your sign-off block): > > Acked-for-Backlight-by: Lee Jones > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 347F0C433E0 for ; Wed, 10 Feb 2021 13:13:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF78F64E3B for ; Wed, 10 Feb 2021 13:13:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231397AbhBJNNe (ORCPT ); Wed, 10 Feb 2021 08:13:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230470AbhBJNNW (ORCPT ); Wed, 10 Feb 2021 08:13:22 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50994C06178A for ; Wed, 10 Feb 2021 05:12:41 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id o15so16388wmq.5 for ; Wed, 10 Feb 2021 05:12:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=06TLiUMrg/gK1BCnrYazHzAso9O/vviLp5XeKWLC8Nc=; b=TcF3i2gwx5Tmi229Lswr8tHwSUp4FnGe8selhPmEPLFiHGwzECmsrru4FPqmpaOiXn wEWmtRqKhpxLqH1/SA7hB9H8LmOxmMCIoeyx5No97BLmyBg+mUPvPgK5qScOYkzG8Hjm LPMMTACRlQpSKp5yoKEl1ljjux4prEN58bKsQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=06TLiUMrg/gK1BCnrYazHzAso9O/vviLp5XeKWLC8Nc=; b=UPxNbjLtGZEjtk8WjSO7YLjkOE3sx9g7TDoNqimiiaX8FGm59qzT+7fzjm7noNvGsZ K6kSPZzTb/OCD2NkP4PVQl9bf9T+OtN+eg/v3e4wtHUy1JCmUV/jpTD+kuIQI6DePsnS v32747MhPIWE1swPeBO1eODxIZm7DwscBIcNlpjDcxcS4wcR+UUW/aBptopEwsbtyLGR 8A0g3v60dns2isid9Zn76DYM4kQoJdiTGNcFk2aRutOUJ/UUuJoAzNRhn79kXumOtHZ/ uV3hE091+K4ulwic6Ij6kEDDh20yziDAmpmLBBu6i1Km2DGeDnsR1R4hQQA61Np9w84S CAcQ== X-Gm-Message-State: AOAM530amJ9jqv87iYi1yd1fT/KA0O0F4UtwG3Hm5K4g7qz1BT2OIUtp 8I3hjU0bKdCGnB7U8b440mot0g== X-Google-Smtp-Source: ABdhPJy4ZuPo59mA1wIBRKapj8He5a/779Cqw/Hlzs8kQbtN9+Z+zVO8u1tp1fHi0Wh5ZYDbsodCMQ== X-Received: by 2002:a1c:49d7:: with SMTP id w206mr2842211wma.63.1612962760064; Wed, 10 Feb 2021 05:12:40 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z15sm2907980wrt.8.2021.02.10.05.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 05:12:39 -0800 (PST) Date: Wed, 10 Feb 2021 14:12:37 +0100 From: Daniel Vetter To: Lee Jones Cc: Julia Lawall , Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] video: use getter/setter functions Message-ID: Mail-Followup-To: Lee Jones , Julia Lawall , Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> <20210210082341.GH220368@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210210082341.GH220368@dell> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Feb 10, 2021 at 08:23:41AM +0000, Lee Jones wrote: > On Tue, 09 Feb 2021, Julia Lawall wrote: > > > Use getter and setter functions, for platform_device structures and a > > spi_device structure. > > > > Signed-off-by: Julia Lawall > > > > --- > > drivers/video/backlight/qcom-wled.c | 2 +- > > This patch is fine. > > Could you please split it out and submit it separately though please. Or just apply the entire patch through backlight tree, there's nothing going on in fbdev anyway I think. Acked-by: Daniel Vetter > > > drivers/video/fbdev/amifb.c | 4 ++-- > > drivers/video/fbdev/da8xx-fb.c | 4 ++-- > > drivers/video/fbdev/imxfb.c | 2 +- > > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 6 +++--- > > drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 4 ++-- > > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++-- > > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 2 +- > > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 2 +- > > drivers/video/fbdev/xilinxfb.c | 2 +- > > 10 files changed, 16 insertions(+), 16 deletions(-) > > ...] > > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > > index 3bc7800eb0a9..091f07e7c145 100644 > > --- a/drivers/video/backlight/qcom-wled.c > > +++ b/drivers/video/backlight/qcom-wled.c > > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev) > > > > static int wled_remove(struct platform_device *pdev) > > { > > - struct wled *wled = dev_get_drvdata(&pdev->dev); > > + struct wled *wled = platform_get_drvdata(pdev); > > > > mutex_destroy(&wled->lock); > > cancel_delayed_work_sync(&wled->ovp_work); > > For my own reference (apply this as-is to your sign-off block): > > Acked-for-Backlight-by: Lee Jones > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 602C3C433E0 for ; Wed, 10 Feb 2021 13:13:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CF0564DEE for ; Wed, 10 Feb 2021 13:13:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CF0564DEE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fS3HazaBaYznlZz7sddhRfbmvTu4C2DmNeP9Q7ncLRE=; b=hJAO3KEuRn8DsGI+U+HhTtNBC kJ5JZj9jIgA0fjtQSqmSKfRv4SxMj4Lu1UWCdoIR0dLOR4HCagaHtnkeoQ08FpLyUD1+OpkjH7Dml opbdL5IpfHlKDHnkcedlMaAliVhkIWocd4TTyoLZVMyPO3boV/57l7foZnMFHq9fHZAKneovTi7nO KrPOOBxsCRH+PJUwO1qxzJTDmMi8M5ARBD22nKlT3HbmFVxPO3DXUcNPnqjaTt4v9Mvut7FNC82FY AmkhbDvL4Ldwz2rTm1KwVxed9Ma6dEFBBQVRVRT5odSrU62EBthN4DKaqG+chKKyVOYA2inoRXXtU hOuF1cQfA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9pIR-0007M2-SR; Wed, 10 Feb 2021 13:12:43 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9pIP-0007L1-7p for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 13:12:42 +0000 Received: by mail-wm1-x332.google.com with SMTP id o15so16389wmq.5 for ; Wed, 10 Feb 2021 05:12:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=06TLiUMrg/gK1BCnrYazHzAso9O/vviLp5XeKWLC8Nc=; b=TcF3i2gwx5Tmi229Lswr8tHwSUp4FnGe8selhPmEPLFiHGwzECmsrru4FPqmpaOiXn wEWmtRqKhpxLqH1/SA7hB9H8LmOxmMCIoeyx5No97BLmyBg+mUPvPgK5qScOYkzG8Hjm LPMMTACRlQpSKp5yoKEl1ljjux4prEN58bKsQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=06TLiUMrg/gK1BCnrYazHzAso9O/vviLp5XeKWLC8Nc=; b=dkgAbkuALeyZD5Jkz/jANdWaSe6j8scy9RTr+VqO5PiiaCzTjyWOyuh1K76Ilow5jf tBfxLLz+DBN246QSbXcSSabElt4en8WOgmIxH/QL3yX20UtI2Sy3LhSM7WT44y4Sdy2p QjEkHt27SBfw8wHKFqgi5wooMcaiRGt5DkRniPqcAx83w/AyJ0kjpaKxBPViFpDjE71E UYVISQ/aUxEOxbf+gWYd0cmiq/8MutMCcmdPf/EvfYm10ZzuZaqdjpjZkg6joFZjTZze WOZYrxiYIKiqPDVmKyPu5qq+SlxLAPIkZlKuKriJEycTJrRrdLyqS5QOlCK9wfoRAf4G Qttg== X-Gm-Message-State: AOAM533lX8FE9lWN4msxKw+YsctLFfJvFqKdkULDpY1ZghKnOMy9Q6j3 MuQeCV0kL7RTH3RzGBY1+WWIdg== X-Google-Smtp-Source: ABdhPJy4ZuPo59mA1wIBRKapj8He5a/779Cqw/Hlzs8kQbtN9+Z+zVO8u1tp1fHi0Wh5ZYDbsodCMQ== X-Received: by 2002:a1c:49d7:: with SMTP id w206mr2842211wma.63.1612962760064; Wed, 10 Feb 2021 05:12:40 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z15sm2907980wrt.8.2021.02.10.05.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 05:12:39 -0800 (PST) Date: Wed, 10 Feb 2021 14:12:37 +0100 From: Daniel Vetter To: Lee Jones Subject: Re: [PATCH] video: use getter/setter functions Message-ID: Mail-Followup-To: Lee Jones , Julia Lawall , Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> <20210210082341.GH220368@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210210082341.GH220368@dell> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_081241_304293_80D7E49C X-CRM114-Status: GOOD ( 21.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , linux-omap@vger.kernel.org, Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Simek , Julia Lawall , linux-fbdev@vger.kernel.org, Andy Gross , NXP Linux Team , Pengutronix Kernel Team , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBGZWIgMTAsIDIwMjEgYXQgMDg6MjM6NDFBTSArMDAwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+IE9uIFR1ZSwgMDkgRmViIDIwMjEsIEp1bGlhIExhd2FsbCB3cm90ZToKPiAKPiA+IFVzZSBn ZXR0ZXIgYW5kIHNldHRlciBmdW5jdGlvbnMsIGZvciBwbGF0Zm9ybV9kZXZpY2Ugc3RydWN0dXJl cyBhbmQgYQo+ID4gc3BpX2RldmljZSBzdHJ1Y3R1cmUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6 IEp1bGlhIExhd2FsbCA8SnVsaWEuTGF3YWxsQGlucmlhLmZyPgo+ID4gCj4gPiAtLS0KPiA+ICBk cml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgIDIgKy0KPiAKPiBUaGlzIHBhdGNoIGlzIGZpbmUuCj4gCj4gQ291bGQg eW91IHBsZWFzZSBzcGxpdCBpdCBvdXQgYW5kIHN1Ym1pdCBpdCBzZXBhcmF0ZWx5IHRob3VnaCBw bGVhc2UuCgpPciBqdXN0IGFwcGx5IHRoZSBlbnRpcmUgcGF0Y2ggdGhyb3VnaCBiYWNrbGlnaHQg dHJlZSwgdGhlcmUncyBub3RoaW5nCmdvaW5nIG9uIGluIGZiZGV2IGFueXdheSBJIHRoaW5rLgoK QWNrZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cgo+IAo+ID4g IGRyaXZlcnMvdmlkZW8vZmJkZXYvYW1pZmIuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAgNCArKy0tCj4gPiAgZHJpdmVycy92aWRlby9mYmRldi9kYTh4eC1m Yi5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA0ICsrLS0KPiA+ ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L2lteGZiLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgIDIgKy0KPiA+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29t YXBmYi9kaXNwbGF5cy9wYW5lbC1sZ3BoaWxpcHMtbGIwMzVxMDIuYyB8ICAgIDYgKysrLS0tCj4g PiAgZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvZHNzL2RwaS5jICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgICA0ICsrLS0KPiA+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAy L29tYXBmYi9kc3MvZHNpLmMgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDQgKystLQo+ ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rzcy9oZG1pNC5jICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAgMiArLQo+ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIv b21hcGZiL2Rzcy9oZG1pNS5jICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMiArLQo+ID4g IGRyaXZlcnMvdmlkZW8vZmJkZXYveGlsaW54ZmIuYyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAgMiArLQo+ID4gIDEwIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlv bnMoKyksIDE2IGRlbGV0aW9ucygtKQo+IAo+IC4uLl0KPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0 L3Fjb20td2xlZC5jCj4gPiBpbmRleCAzYmM3ODAwZWIwYTkuLjA5MWYwN2U3YzE0NSAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3Fjb20td2xlZC5jCj4gPiArKysgYi9k cml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYwo+ID4gQEAgLTE2OTIsNyArMTY5Miw3 IEBAIHN0YXRpYyBpbnQgd2xlZF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ ID4gIAo+ID4gIHN0YXRpYyBpbnQgd2xlZF9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikKPiA+ICB7Cj4gPiAtCXN0cnVjdCB3bGVkICp3bGVkID0gZGV2X2dldF9kcnZkYXRhKCZw ZGV2LT5kZXYpOwo+ID4gKwlzdHJ1Y3Qgd2xlZCAqd2xlZCA9IHBsYXRmb3JtX2dldF9kcnZkYXRh KHBkZXYpOwo+ID4gIAo+ID4gIAltdXRleF9kZXN0cm95KCZ3bGVkLT5sb2NrKTsKPiA+ICAJY2Fu Y2VsX2RlbGF5ZWRfd29ya19zeW5jKCZ3bGVkLT5vdnBfd29yayk7Cj4gCj4gRm9yIG15IG93biBy ZWZlcmVuY2UgKGFwcGx5IHRoaXMgYXMtaXMgdG8geW91ciBzaWduLW9mZiBibG9jayk6Cj4gCj4g ICBBY2tlZC1mb3ItQmFja2xpZ2h0LWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3Jn Pgo+IAo+IC0tIAo+IExlZSBKb25lcyBb5p2O55C85pavXQo+IFNlbmlvciBUZWNobmljYWwgTGVh ZCAtIERldmVsb3BlciBTZXJ2aWNlcwo+IExpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3 YXJlIGZvciBBcm0gU29Dcwo+IEZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJs b2cKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK Ci0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpo dHRwOi8vYmxvZy5mZndsbC5jaAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D7BC433E0 for ; Wed, 10 Feb 2021 13:12:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A03F164DD8 for ; Wed, 10 Feb 2021 13:12:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A03F164DD8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 112446EC78; Wed, 10 Feb 2021 13:12:43 +0000 (UTC) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 571696E24E for ; Wed, 10 Feb 2021 13:12:41 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id j11so1790257wmi.3 for ; Wed, 10 Feb 2021 05:12:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=06TLiUMrg/gK1BCnrYazHzAso9O/vviLp5XeKWLC8Nc=; b=TcF3i2gwx5Tmi229Lswr8tHwSUp4FnGe8selhPmEPLFiHGwzECmsrru4FPqmpaOiXn wEWmtRqKhpxLqH1/SA7hB9H8LmOxmMCIoeyx5No97BLmyBg+mUPvPgK5qScOYkzG8Hjm LPMMTACRlQpSKp5yoKEl1ljjux4prEN58bKsQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=06TLiUMrg/gK1BCnrYazHzAso9O/vviLp5XeKWLC8Nc=; b=jeeQRORJGR5dZHu8Qex3vVQEFUuBtJoiA8VVpiLVPBP4KGb4vgIHmGLIuC6DydrH+R B8Z4O/C53vYNPy40UulbAZewZGyCJMSWhdwRPvaQYlD6OT81K+e+4yDCStf0xPkVM1iZ oEIQ10ESfpvsSnX1YgbByAIb7FMDREE2PpnM6HuKli2n/bTpWE50uvTpCYd9OO99bLOs bQCdfJrBLVO99ozcjmWjYugZA0yIkT87LVRkJnmja6tW2j1T84RUfWQ/BBLG8JJTTEE9 OVZsXIk4yItmWwqigD7BCgiYGCphI3+cqH0c9z8oy4Z1NltOBWrW3+zmtfAa+h/yVR2q ylhQ== X-Gm-Message-State: AOAM530MjZIEt4QNOUIAUjD/N0xb1JxEJ9dZ5p1p2Ll4e6r8SRoclZC5 Mw2B1E5GJeMXFCew2YCcFPlW7w== X-Google-Smtp-Source: ABdhPJy4ZuPo59mA1wIBRKapj8He5a/779Cqw/Hlzs8kQbtN9+Z+zVO8u1tp1fHi0Wh5ZYDbsodCMQ== X-Received: by 2002:a1c:49d7:: with SMTP id w206mr2842211wma.63.1612962760064; Wed, 10 Feb 2021 05:12:40 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z15sm2907980wrt.8.2021.02.10.05.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 05:12:39 -0800 (PST) Date: Wed, 10 Feb 2021 14:12:37 +0100 From: Daniel Vetter To: Lee Jones Subject: Re: [PATCH] video: use getter/setter functions Message-ID: Mail-Followup-To: Lee Jones , Julia Lawall , Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> <20210210082341.GH220368@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210210082341.GH220368@dell> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , linux-omap@vger.kernel.org, Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Simek , Julia Lawall , linux-fbdev@vger.kernel.org, Andy Gross , NXP Linux Team , Pengutronix Kernel Team , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCBGZWIgMTAsIDIwMjEgYXQgMDg6MjM6NDFBTSArMDAwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+IE9uIFR1ZSwgMDkgRmViIDIwMjEsIEp1bGlhIExhd2FsbCB3cm90ZToKPiAKPiA+IFVzZSBn ZXR0ZXIgYW5kIHNldHRlciBmdW5jdGlvbnMsIGZvciBwbGF0Zm9ybV9kZXZpY2Ugc3RydWN0dXJl cyBhbmQgYQo+ID4gc3BpX2RldmljZSBzdHJ1Y3R1cmUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6 IEp1bGlhIExhd2FsbCA8SnVsaWEuTGF3YWxsQGlucmlhLmZyPgo+ID4gCj4gPiAtLS0KPiA+ICBk cml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgIDIgKy0KPiAKPiBUaGlzIHBhdGNoIGlzIGZpbmUuCj4gCj4gQ291bGQg eW91IHBsZWFzZSBzcGxpdCBpdCBvdXQgYW5kIHN1Ym1pdCBpdCBzZXBhcmF0ZWx5IHRob3VnaCBw bGVhc2UuCgpPciBqdXN0IGFwcGx5IHRoZSBlbnRpcmUgcGF0Y2ggdGhyb3VnaCBiYWNrbGlnaHQg dHJlZSwgdGhlcmUncyBub3RoaW5nCmdvaW5nIG9uIGluIGZiZGV2IGFueXdheSBJIHRoaW5rLgoK QWNrZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cgo+IAo+ID4g IGRyaXZlcnMvdmlkZW8vZmJkZXYvYW1pZmIuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAgNCArKy0tCj4gPiAgZHJpdmVycy92aWRlby9mYmRldi9kYTh4eC1m Yi5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA0ICsrLS0KPiA+ ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L2lteGZiLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgIDIgKy0KPiA+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29t YXBmYi9kaXNwbGF5cy9wYW5lbC1sZ3BoaWxpcHMtbGIwMzVxMDIuYyB8ICAgIDYgKysrLS0tCj4g PiAgZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvZHNzL2RwaS5jICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgICA0ICsrLS0KPiA+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAy L29tYXBmYi9kc3MvZHNpLmMgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDQgKystLQo+ ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rzcy9oZG1pNC5jICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAgMiArLQo+ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIv b21hcGZiL2Rzcy9oZG1pNS5jICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMiArLQo+ID4g IGRyaXZlcnMvdmlkZW8vZmJkZXYveGlsaW54ZmIuYyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAgMiArLQo+ID4gIDEwIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlv bnMoKyksIDE2IGRlbGV0aW9ucygtKQo+IAo+IC4uLl0KPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYyBiL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0 L3Fjb20td2xlZC5jCj4gPiBpbmRleCAzYmM3ODAwZWIwYTkuLjA5MWYwN2U3YzE0NSAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3Fjb20td2xlZC5jCj4gPiArKysgYi9k cml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYwo+ID4gQEAgLTE2OTIsNyArMTY5Miw3 IEBAIHN0YXRpYyBpbnQgd2xlZF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ ID4gIAo+ID4gIHN0YXRpYyBpbnQgd2xlZF9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikKPiA+ICB7Cj4gPiAtCXN0cnVjdCB3bGVkICp3bGVkID0gZGV2X2dldF9kcnZkYXRhKCZw ZGV2LT5kZXYpOwo+ID4gKwlzdHJ1Y3Qgd2xlZCAqd2xlZCA9IHBsYXRmb3JtX2dldF9kcnZkYXRh KHBkZXYpOwo+ID4gIAo+ID4gIAltdXRleF9kZXN0cm95KCZ3bGVkLT5sb2NrKTsKPiA+ICAJY2Fu Y2VsX2RlbGF5ZWRfd29ya19zeW5jKCZ3bGVkLT5vdnBfd29yayk7Cj4gCj4gRm9yIG15IG93biBy ZWZlcmVuY2UgKGFwcGx5IHRoaXMgYXMtaXMgdG8geW91ciBzaWduLW9mZiBibG9jayk6Cj4gCj4g ICBBY2tlZC1mb3ItQmFja2xpZ2h0LWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3Jn Pgo+IAo+IC0tIAo+IExlZSBKb25lcyBb5p2O55C85pavXQo+IFNlbmlvciBUZWNobmljYWwgTGVh ZCAtIERldmVsb3BlciBTZXJ2aWNlcwo+IExpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3 YXJlIGZvciBBcm0gU29Dcwo+IEZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJs b2cKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK Ci0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpo dHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK