From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07A9CC433E0 for ; Wed, 10 Feb 2021 16:16:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD91864E77 for ; Wed, 10 Feb 2021 16:16:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231978AbhBJQQj (ORCPT ); Wed, 10 Feb 2021 11:16:39 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:36698 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231873AbhBJQQh (ORCPT ); Wed, 10 Feb 2021 11:16:37 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D5D40DD; Wed, 10 Feb 2021 17:15:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1612973753; bh=YJ27IC32WQwEVgulGqZWPtZvgX7OJVwTZloEWIJv/a8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dbkdpSICoeMyJku9RfEgmyNwYYsT8fLmaRAVCUgkgrFOsIV6KGJp+gf8KFkD2ZVM/ WVjipBZfw1s7vKo2xfQA/uLuqhTUzf/HYBbaZBA3RK9Of8w6iANA38s0brU9pak+70 iTPoir0TQ6emZxi8GNVuCfisLnjciFlKWnyAl/Dg= Date: Wed, 10 Feb 2021 18:15:29 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: Mauro Carvalho Chehab , Sakari Ailus , linux-media@vger.kernel.org, linux-next@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Stephen Rothwell , Nathan Chancellor Subject: Re: [PATCH] media: i2c: max9271: Add MODULE_* macros Message-ID: References: <20210210154908.1227203-1-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210210154908.1227203-1-jacopo+renesas@jmondi.org> Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Hi Jacopo, Thank you for the patch. On Wed, Feb 10, 2021 at 04:49:08PM +0100, Jacopo Mondi wrote: > Since commit 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 > a module") the max9271 library is built as a module but no > MODULE_*() attributes were specified, causing a build error > due to missing license information. > > ERROR: modpost: missing MODULE_LICENSE() in drivers/media/i2c/max9271.o > > Fix this by adding MODULE attributes to the driver. > > Fixes: 7f03d9fefcc5 ("media: i2c: Kconfig: Make MAX9271 a module") > Reported-by: Stephen Rothwell > Reported-by: Nathan Chancellor > Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/max9271.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/i2c/max9271.c b/drivers/media/i2c/max9271.c > index c247db569bab..c495582dcff6 100644 > --- a/drivers/media/i2c/max9271.c > +++ b/drivers/media/i2c/max9271.c > @@ -18,6 +18,7 @@ > > #include > #include > +#include > > #include "max9271.h" > > @@ -339,3 +340,7 @@ int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest) > return 0; > } > EXPORT_SYMBOL_GPL(max9271_set_translation); > + > +MODULE_DESCRIPTION("Maxim MAX9271 GMSL Serializer"); > +MODULE_AUTHOR("Jacopo Mondi"); > +MODULE_LICENSE("GPL v2"); -- Regards, Laurent Pinchart