All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hemansh Agnihotri <hemanshagnihotri27@gmail.com>
Cc: johan@kernel.org, elder@kernel.org, devel@driverdev.osuosl.org,
	greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: greybus: Added do - while in multi statement macro
Date: Thu, 11 Feb 2021 11:00:18 +0100	[thread overview]
Message-ID: <YCUAMgFa6i9vl9An@kroah.com> (raw)
In-Reply-To: <20210211095444.54447-1-hemanshagnihotri27@gmail.com>

On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote:
> This patch add fixes an checkpatch error for "Macros with multiple statements
> should be enclosed in a do - while loop"
> 
> Signed-off-by: Hemansh Agnihotri <hemanshagnihotri27@gmail.com>

Any reason you didn't test-build your patch before sending it out?

That's a bit rude to reviewers :(

Please always do that.

thanks,

greg k-h

  reply	other threads:[~2021-02-11 10:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11  9:54 [PATCH 1/1] staging: greybus: Added do - while in multi statement macro Hemansh Agnihotri
2021-02-11 10:00 ` Greg KH [this message]
2021-02-11 10:10   ` [greybus-dev] " Viresh Kumar
2021-02-15 10:52     ` Dan Carpenter
2021-02-11 13:07 ` kernel test robot
2021-02-11 13:07   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCUAMgFa6i9vl9An@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=hemanshagnihotri27@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.