All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 5/5] close_range: Add test
Date: Fri, 12 Feb 2021 14:23:06 +0100	[thread overview]
Message-ID: <YCaBOqMhTqNlRhH5@yuki.lan> (raw)
In-Reply-To: <20210211174543.25003-6-rpalethorpe@suse.com>

Hi!
Pushed with small changes, thanks.

* Added a runtest file entry

* Add .needs_root which is what we have for tests that utilize loop devices

* Reformatted the top level comment so it's picked by docparser

* Shortened the git hash to 12 characters, since that's what we have in
  the rest of the tests


Also we are missing simple test for a negative cases, that is:

* Check that EINVAL is returned if we pass ~0 to flags

* And check that EINVAL is returned when fd < fd_max as well


And one more a bit more complicated test:

We should also get EMFILE if we do CLOSE_RANGE_UNSHARE and the parent
rlimit is exhausted.


Will you write these tests as well, or should I have a look?

-- 
Cyril Hrubis
chrubis@suse.cz

  parent reply	other threads:[~2021-02-12 13:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 17:45 [LTP] [PATCH v2 0/5] Add close_range01, SAFE_DUP2 and SAFE_CLONE Richard Palethorpe
2021-02-11 17:45 ` [LTP] [PATCH v2 1/5] API: Add close_range syscall wrapper Richard Palethorpe
2021-02-11 17:45 ` [LTP] [PATCH v2 2/5] API: Add SAFE_DUP2 Richard Palethorpe
2021-02-11 17:45 ` [LTP] [PATCH v2 3/5] API: Fix clone.h Richard Palethorpe
2021-02-11 17:45 ` [LTP] [PATCH v2 4/5] API: Add tst_clone Richard Palethorpe
2021-02-11 17:45 ` [LTP] [PATCH v2 5/5] close_range: Add test Richard Palethorpe
2021-02-12 13:05   ` Petr Vorel
2021-02-12 13:16     ` Cyril Hrubis
2021-02-12 13:31       ` Petr Vorel
2021-02-12 13:23   ` Cyril Hrubis [this message]
2021-02-12 14:09     ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCaBOqMhTqNlRhH5@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.