From: Andrew Lunn <andrew@lunn.ch>
To: Bjarni Jonasson <bjarni.jonasson@microchip.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Antoine Tenart <atenart@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Steen Hegelund <steen.hegelund@microchip.com>
Subject: Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514
Date: Fri, 12 Feb 2021 16:20:27 +0100 [thread overview]
Message-ID: <YCacux8K+ocWbRQ2@lunn.ch> (raw)
In-Reply-To: <20210212140643.23436-1-bjarni.jonasson@microchip.com>
On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote:
> +static u32 vsc85xx_csr_read(struct phy_device *phydev,
> + enum csr_target target, u32 reg);
> +static int vsc85xx_csr_write(struct phy_device *phydev,
> + enum csr_target target, u32 reg, u32 val);
> +
Hi Bjarni
No forward definitions please. Move the code around so they are not
required. Sometimes it is best to do such a move as a preparation
patch.
> @@ -1569,8 +1664,16 @@ static int vsc8514_config_pre_init(struct phy_device *phydev)
> {0x16b2, 0x00007000},
> {0x16b4, 0x00000814},
> };
> + struct device *dev = &phydev->mdio.dev;
> unsigned int i;
> u16 reg;
> + int ret;
Hard to say from the limited context, but is reverse christmass tree
being preserved here?
Andrew
next prev parent reply other threads:[~2021-02-12 15:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 14:06 [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514 Bjarni Jonasson
2021-02-12 14:06 ` [PATCH net v1 2/3] net: phy: mscc: improved serdes calibration applied " Bjarni Jonasson
2021-02-12 16:24 ` Vladimir Oltean
2021-02-12 14:06 ` [PATCH net v1 3/3] net: phy: mscc: coma mode disabled for VSC8514 Bjarni Jonasson
2021-02-12 16:32 ` Vladimir Oltean
2021-02-15 9:36 ` Bjarni.Jonasson
2021-02-12 15:20 ` Andrew Lunn [this message]
2021-02-15 9:15 ` [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514 Bjarni.Jonasson
2021-02-12 15:54 ` Andrew Lunn
2021-02-15 9:27 ` Bjarni.Jonasson
2021-02-12 16:23 ` Vladimir Oltean
2021-02-12 18:53 ` Jakub Kicinski
2021-02-15 9:38 ` Bjarni.Jonasson
2021-02-12 22:38 ` kernel test robot
2021-02-12 22:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCacux8K+ocWbRQ2@lunn.ch \
--to=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=steen.hegelund@microchip.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.