From: Greg KH <gregkh@linuxfoundation.org>
To: Min Li <min.li.xe@renesas.com>
Cc: "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
"dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support
Date: Fri, 12 Feb 2021 16:55:24 +0100 [thread overview]
Message-ID: <YCak7Eu2X0dzapPz@kroah.com> (raw)
In-Reply-To: <OSBPR01MB4773472EE0C8D34456C79121BA8B9@OSBPR01MB4773.jpnprd01.prod.outlook.com>
On Fri, Feb 12, 2021 at 03:44:52PM +0000, Min Li wrote:
> > >
> > > -set combomode
> > > -get dpll's state
> > > -get dpll's ffo
> > >
> > > This driver must work with Renesas MFD driver to access SMU through
> > > I2C/SPI.
> > >
> > > Changes since v1:
> > > -Provide more background for purpose of the change.
> > > -Provide compat_ioctl support
> > > -Fix ioctl cmd definition
> >
> > This "changes" list goes below the --- line.
> >
>
> Sorry, is this a problem that you are requesting me to address? I am bit confused...
Yes, please place that list of changes below the --- line in your patch.
The documentation says to do this, right?
> > And you seem to have ignored my review, especially about documenting the
> > sysfs files here, please do that as I can not accept this patch as-is.
> >
>
> If I come up with an rsmu.rst under Documentation/driver-api, is that something you are looking for?
No, all sysfs files need to be documented in Documentation/ABI/
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-12 15:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 1:16 [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support min.li.xe
2021-02-12 7:39 ` Greg KH
2021-02-12 15:39 ` Min Li
2021-02-12 15:48 ` Greg KH
2021-02-12 16:02 ` Min Li
2021-02-12 16:22 ` Greg KH
2021-02-12 7:40 ` Greg KH
2021-02-12 15:44 ` Min Li
2021-02-12 15:55 ` Greg KH [this message]
2021-02-12 16:04 ` Min Li
2021-02-12 19:06 ` Min Li
2021-02-13 8:28 ` Greg KH
2021-02-16 19:50 ` Min Li
2021-02-17 7:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCak7Eu2X0dzapPz@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.