From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: linux-gpio@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Imre Deak <imre.deak@intel.com>
Subject: Re: Replace raw_spin_lock_irqsave with raw_spin_lock
Date: Fri, 12 Feb 2021 18:42:02 +0200 [thread overview]
Message-ID: <YCav2qVWsUKbrOK4@smile.fi.intel.com> (raw)
In-Reply-To: <YCauUncGVwYPfBfQ@smile.fi.intel.com>
On Fri, Feb 12, 2021 at 06:35:30PM +0200, Andy Shevchenko wrote:
> Hi, Mika!
>
> There is an interesting discussion [1] going on about necessity of the
> _irqsave/_irqrestore variants of spin lock in the IRQ handler.
>
> It appears that in our driver(s) we have also such variants of spin locks in
> use. Do you have any idea why is it so?
Okay, this is me, who did it in a copy'n'paste manner in the commit
e64fbfa51e8f ("pinctrl: intel: Protect IO in few call backs by lock").
> A bonus question, why do we use _NO_THREAD flag explicitly as per Thomas [2]
> this won't work well with RT kernels?
Okay, this part is explained in the commit 1a7d1cb81eb2 ("pinctrl: intel:
Prevent force threading of the interrupt handler").
> [1]: https://lore.kernel.org/linux-gpio/1612774577-55943-1-git-send-email-luojiaxing@huawei.com/T/#u
> [2]: https://lore.kernel.org/linux-i2c/87zh2s8buh.fsf@nanos.tec.linutronix.de/
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-02-12 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 16:35 Replace raw_spin_lock_irqsave with raw_spin_lock Andy Shevchenko
2021-02-12 16:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCav2qVWsUKbrOK4@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=imre.deak@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.