From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] keyctl05: TCONF on FIPS mode
Date: Fri, 12 Feb 2021 20:10:14 +0100 [thread overview]
Message-ID: <YCbSlgcTS8XM5yp/@pevik> (raw)
In-Reply-To: <YCamj5IAuyPMOcBo@yuki.lan>
Hi Cyril,
> Hi!
> > + int is_asymmetric = !strcmp(type, "asymmetric");
> > +
> > TEST(add_key(type, "desc", payload, plen, KEY_SPEC_SESSION_KEYRING));
> > if (TST_RET < 0) {
> > + if (TST_ERR == EINVAL && is_asymmetric && tst_fips_enabled()) {
> ^
> I guess that
> we can save
> the value in
> test setup
> instead of
> re-reading it
> on every
> iteration.
> Other than that it looks good to me.
Good point, thanks! Moved to variable set at setup and merged.
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Kind regards,
Petr
next prev parent reply other threads:[~2021-02-12 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 13:04 [LTP] [PATCH 1/2] lib: Add function to detect FIPS mode Petr Vorel
2021-02-02 13:04 ` [LTP] [PATCH 2/2] keyctl05: TCONF on " Petr Vorel
2021-02-12 16:02 ` Cyril Hrubis
2021-02-12 19:10 ` Petr Vorel [this message]
2021-02-12 16:00 ` [LTP] [PATCH 1/2] lib: Add function to detect " Cyril Hrubis
2021-02-12 18:59 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCbSlgcTS8XM5yp/@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.