From: Alexey Dobriyan <adobriyan@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] proc: Convert S_<FOO> permission uses to octal
Date: Sat, 13 Feb 2021 11:02:50 +0300 [thread overview]
Message-ID: <YCeHqqQIBrdJd/2C@localhost.localdomain> (raw)
In-Reply-To: <m1im6x0wtv.fsf@fess.ebiederm.org>
On Fri, Feb 12, 2021 at 04:01:48PM -0600, Eric W. Biederman wrote:
> Joe Perches <joe@perches.com> writes:
>
> > Convert S_<FOO> permissions to the more readable octal.
> Something like that should be able to address the readability while
> still using symbolic constants.
Macros are easy. I've sent a patch long time ago which does essentially
#define rwxrwxrwx 0777
...
But then kernel will start using something nobode else does.
This whole issue is like sizeof(*ptr) vs sizeof(sizeof(struct S)).
No preferred way overall with ever vigilant checkpatch.pl guarding
kernel 24/7. :-)
prev parent reply other threads:[~2021-02-13 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 19:11 [PATCH] proc: Convert S_<FOO> permission uses to octal Joe Perches
2021-02-12 22:01 ` Eric W. Biederman
2021-02-12 22:19 ` Matthew Wilcox
2021-02-12 23:48 ` Eric W. Biederman
2021-02-13 0:42 ` Joe Perches
2021-02-12 22:51 ` Joe Perches
2021-02-12 23:44 ` Eric W. Biederman
2021-02-13 0:39 ` Joe Perches
2021-02-13 8:02 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCeHqqQIBrdJd/2C@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.