From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roger Pau =?utf-8?B?TW9ubsOp?= <royger@freebsd.org>
Date: Sun, 14 Feb 2021 08:25:27 +0100
Subject: [PATCH] odroid-go2: remove setting
 SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR
In-Reply-To: <20953434.EfDdHjke4D@phil>
References: <20210213155901.10247-1-royger@FreeBSD.org>
 <20953434.EfDdHjke4D@phil>
Message-ID: <YCjQZylNagrVZzZe@Air-de-Roger>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sat, Feb 13, 2021 at 11:45:50PM +0100, Heiko Stuebner wrote:
> Hi Roger,
> 
> Am Samstag, 13. Februar 2021, 16:59:01 CET schrieb Roger Pau Monne:
> > From: Roger Pau Monn? <royger@FreeBSD.org>
> > 
> > Using a non-default SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR setting makes the
> > resulting u-boot-rockchip.bin unbootable, as it gets stuck after SPL.
> > Removing the setting from the defconfig allows U-Boot to load
> > successfully.
> 
> Hmm, I'd disagree slightly.
> 
> In the rockchip-common.h the CONFIG_SPL_PAD_TO is defined as
> 
> /* ((CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR - 64) * 512) */
> #define CONFIG_SPL_PAD_TO		8355840
> 
> so it's a static value but based on the MMCSD_RAW_MODE... config option.
> 
> So instead of mandating one specific MMCSD_RAW_MODE... value
> that CONFIG_SPL_PAD_TO should be defined based on the the
> actual config value of CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR
> and not some static number that then gets enforced for all boards.

Sure, I can fix CONFIG_SPL_PAD_TO to be calculated based on
MMCSD_RAW_MODE..., but why does this board use a different sector? Is
it just to use less space?

I guess it's not possible to add a comment to odroid-go2_defconfig to
clarify this, as it would get dropped by updates to the file?

Thanks, Roger.