From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88276C433E6 for ; Mon, 1 Mar 2021 20:39:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EBC4601FC for ; Mon, 1 Mar 2021 20:39:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243145AbhCAUhd (ORCPT ); Mon, 1 Mar 2021 15:37:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:50820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243600AbhCAUdz (ORCPT ); Mon, 1 Mar 2021 15:33:55 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9107061601; Mon, 1 Mar 2021 18:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614624793; bh=RMgVl2CPO1xv43qphx/+Sc8JAROd+Z9d+qNlJBUHTbg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e+O82FIWx0ca3oTBoog9b4ZfE/5Zoscmqw2NU/QKt3J3Bn+QRyetes9ZrPONGwYXZ rLJt5/vIdwntHXmg8yFOn4A6f3vCxobzJ8qxmdNVeGVe4tBXDfYl1rwuq2fZkuypqF wN4pxpiVPwwXLBlC8dx1mulF7+Jn/xsq07A875kI= Date: Mon, 1 Mar 2021 19:52:09 +0100 From: Greg Kroah-Hartman To: Naresh Kamboju Cc: Sasha Levin , linux-stable , lkft-triage@lists.linaro.org, Laurent Pinchart , Jacopo Mondi , Linux-Renesas , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , kieran.bingham+renesas@ideasonboard.com Subject: Re: rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Mon, Mar 01, 2021 at 11:11:26PM +0530, Naresh Kamboju wrote: > On stable rc 5.11 the x86_64 build failed due to below errors/warnings. > > drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup': > drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit > declaration of function 'to_rcar_du_device'; did you mean > 'to_rtc_device'? [-Werror=implicit-function-declaration] > struct rcar_du_device *rcdu = to_rcar_du_device(dev); > ^~~~~~~~~~~~~~~~~ > to_rtc_device > drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization > makes pointer from integer without a cast [-Wint-conversion] > In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0: > drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init': > drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument > 1 of '__drmm_add_action' from incompatible pointer type > [-Werror=incompatible-pointer-types] > ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL); > ^ > include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action' > __drmm_add_action(dev, action, data, #action) > ^~~ > include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *' > but argument is of type 'struct drm_device **' > int __must_check __drmm_add_action(struct drm_device *dev, > ^~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > Reported-by: Naresh Kamboju Very odd, my builds here didn't trigger that, sorry. I'll go drop the offending patch... greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FC2C433E0 for ; Mon, 1 Mar 2021 18:53:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06EF164DDC for ; Mon, 1 Mar 2021 18:53:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06EF164DDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6206B6E88A; Mon, 1 Mar 2021 18:53:15 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D6BC6E88A for ; Mon, 1 Mar 2021 18:53:14 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9107061601; Mon, 1 Mar 2021 18:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614624793; bh=RMgVl2CPO1xv43qphx/+Sc8JAROd+Z9d+qNlJBUHTbg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e+O82FIWx0ca3oTBoog9b4ZfE/5Zoscmqw2NU/QKt3J3Bn+QRyetes9ZrPONGwYXZ rLJt5/vIdwntHXmg8yFOn4A6f3vCxobzJ8qxmdNVeGVe4tBXDfYl1rwuq2fZkuypqF wN4pxpiVPwwXLBlC8dx1mulF7+Jn/xsq07A875kI= Date: Mon, 1 Mar 2021 19:52:09 +0100 From: Greg Kroah-Hartman To: Naresh Kamboju Subject: Re: rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Laurent Pinchart , David Airlie , dri-devel@lists.freedesktop.org, lkft-triage@lists.linaro.org, Linux-Renesas , kieran.bingham+renesas@ideasonboard.com, Jacopo Mondi , linux-stable Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 01, 2021 at 11:11:26PM +0530, Naresh Kamboju wrote: > On stable rc 5.11 the x86_64 build failed due to below errors/warnings. > > drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup': > drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit > declaration of function 'to_rcar_du_device'; did you mean > 'to_rtc_device'? [-Werror=implicit-function-declaration] > struct rcar_du_device *rcdu = to_rcar_du_device(dev); > ^~~~~~~~~~~~~~~~~ > to_rtc_device > drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization > makes pointer from integer without a cast [-Wint-conversion] > In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0: > drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init': > drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument > 1 of '__drmm_add_action' from incompatible pointer type > [-Werror=incompatible-pointer-types] > ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL); > ^ > include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action' > __drmm_add_action(dev, action, data, #action) > ^~~ > include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *' > but argument is of type 'struct drm_device **' > int __must_check __drmm_add_action(struct drm_device *dev, > ^~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > Reported-by: Naresh Kamboju Very odd, my builds here didn't trigger that, sorry. I'll go drop the offending patch... greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel