From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 6/6] zram: Increase timeout according to used devices
Date: Mon, 1 Mar 2021 16:45:14 +0100 [thread overview]
Message-ID: <YD0MCli+ucNvffME@pevik> (raw)
In-Reply-To: <YD0LMzlHtms7WYEi@pevik>
> > Hi!
> > > > + TST_TIMEOUT=$((dev_num*200))
> > > Actually on heavy loaded machine this is not enough due BTRFS.
> > > I can add something like dev_num*600 or even -1 (then previous commit would not
> > > be needed, but IMHO still useful).
> > I would still prefer if we had a timeout there, -1 is for something that
> > cannot be predicted.
> > Also we do not expect machine to be heavily loaded, in that case half of
> > LTP tests would time out.
> > So I would just measure how long the test takes, then multiply it by 5
> > or something like that and put that in as a timeout.
> Do you mean to use high enough static timeout defined before startup (working
> for maximum possible filesystems)? And create tst_set_timeout() for shell as
> independent effort?
BTW looking at the docs for C API tst_set_timeout() is expected to be run in the
setup function. Thus this patchset can be reused (just extended).
Kind regards,
Petr
> Kind regards,
> Petr
next prev parent reply other threads:[~2021-03-01 15:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 19:41 [LTP] [PATCH v2 0/6] zram cleanup Petr Vorel
2021-01-29 19:41 ` [LTP] [PATCH v2 1/6] zram: Calculate dev_num variable Petr Vorel
2021-01-29 19:41 ` [LTP] [PATCH v2 2/6] zram01.sh: Generate test setup variables in setup Petr Vorel
2021-01-29 20:17 ` Petr Vorel
2021-01-30 5:37 ` Li Wang
2021-02-02 7:17 ` Petr Vorel
2021-02-02 11:16 ` Li Wang
2021-02-06 19:59 ` Petr Vorel
2021-02-08 7:11 ` Petr Vorel
2021-02-18 9:00 ` Li Wang
2021-03-01 14:34 ` Cyril Hrubis
2021-03-01 16:04 ` Petr Vorel
2021-01-29 19:41 ` [LTP] [PATCH v2 3/6] zram: Move zram_compress_alg() to zram02.sh Petr Vorel
2021-03-01 14:55 ` Cyril Hrubis
2021-03-01 15:35 ` Petr Vorel
2021-01-29 19:41 ` [LTP] [PATCH v2 4/6] zram: Move test specific functions out of zram_lib.sh Petr Vorel
2021-03-01 14:57 ` Cyril Hrubis
2021-01-29 19:41 ` [LTP] [RFC PATCH v2 5/6] tst_test.sh: Run _tst_setup_timer after $TST_SETUP Petr Vorel
2021-01-29 20:17 ` Petr Vorel
2021-03-01 15:06 ` Cyril Hrubis
2021-01-29 19:41 ` [LTP] [PATCH v2 6/6] zram: Increase timeout according to used devices Petr Vorel
2021-01-29 20:10 ` Petr Vorel
2021-01-29 20:15 ` Petr Vorel
2021-01-30 8:26 ` Li Wang
2021-02-02 7:38 ` Petr Vorel
2021-02-02 11:25 ` Li Wang
2021-03-01 15:14 ` Cyril Hrubis
2021-03-01 15:41 ` Petr Vorel
2021-03-01 15:45 ` Petr Vorel [this message]
2021-03-01 15:48 ` Cyril Hrubis
2021-03-01 16:18 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD0MCli+ucNvffME@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.