From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C435AC43332 for ; Tue, 2 Mar 2021 08:24:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B5FF64DE5 for ; Tue, 2 Mar 2021 08:24:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1836227AbhCBG73 (ORCPT ); Tue, 2 Mar 2021 01:59:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:32816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1577051AbhCBFhw (ORCPT ); Tue, 2 Mar 2021 00:37:52 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 42A646146B; Tue, 2 Mar 2021 05:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614663431; bh=yX8R/LjOcUGHn7E8QsZIMKBDISkHQNvZsgQfi9+ryv0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bJU9KzjLHfl/9E8tw3i6NCPZFOAGdePX+61d3eg1jII1ljWgSZtPyTJE4PdPZLsIm yTUdaIRU34UV0srxahPPEbKT6xbSV4Ngr5tBi9nmHbsB+gTglBzg92bhM4qw/A8tL6 V3xC5dPHa2tDPTZvvTKtEQVqp7OBZwM4kQ8bDO0I= Date: Tue, 2 Mar 2021 06:37:06 +0100 From: Greg KH To: "tiantao (H)" Cc: Tian Tao , zbr@ioremap.net, rikard.falkeborn@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] w1: ds2708 and ds2781 use the new API kobj_to_dev() Message-ID: References: <1614603535-24046-1-git-send-email-tiantao6@hisilicon.com> <9be69246-fb8b-27dc-c459-0f9aa25c5c88@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9be69246-fb8b-27dc-c459-0f9aa25c5c88@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 02, 2021 at 08:51:08AM +0800, tiantao (H) wrote: > Hi: > > 在 2021/3/1 21:09, Greg KH 写道: > > On Mon, Mar 01, 2021 at 08:58:55PM +0800, Tian Tao wrote: > > > fix the below warnning: > > > /drivers/w1/slaves/w1_ds2780.c:93:60-61: WARNING opportunity for > > > kobj_to_dev() > > What creates that warning? > This is reported by coccicheck. Then include that in the changelog text, otherwise this looks like a warning by the complier, which it is not. > > > Signed-off-by: Tian Tao > > > --- > > > drivers/w1/slaves/w1_ds2780.c | 3 ++- > > > drivers/w1/slaves/w1_ds2781.c | 2 +- > > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/w1/slaves/w1_ds2780.c b/drivers/w1/slaves/w1_ds2780.c > > > index c281fe5..3cde1bb 100644 > > > --- a/drivers/w1/slaves/w1_ds2780.c > > > +++ b/drivers/w1/slaves/w1_ds2780.c > > > @@ -90,7 +90,8 @@ static ssize_t w1_slave_read(struct file *filp, struct kobject *kobj, > > > struct bin_attribute *bin_attr, char *buf, > > > loff_t off, size_t count) > > > { > > > - struct device *dev = container_of(kobj, struct device, kobj); > > > + struct device *dev = kobj_to_dev(kobj); > > > + > > Why the extra line here, but not in the other chunk? > > This is reported by checkpatch. > > tiantao@ubuntu:~/mailline/linux-next$ ./scripts/checkpatch.pl > drivers/w1/slaves/w1_ds2780.c > > WARNING: Missing a blank line after declarations > #94: FILE: drivers/w1/slaves/w1_ds2780.c:94: > +       struct device *dev = kobj_to_dev(kobj); > +       return w1_ds2780_io(dev, buf, off, count, 0); Yes, but you made this change in only one of the hunks, and not the other. And, it is a different type of change, only do one "logical" thing per patch. This should be a 2 patch series if you care about the coding style of this driver. Please fix up and resend. thanks, greg k-h