From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Gon Solo <gonsolo@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Andreas Wendleder <andreas.wendleder@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Perf: Clean generated directory.
Date: Tue, 2 Mar 2021 09:23:09 -0300 [thread overview]
Message-ID: <YD4uLRARSI16b9eJ@kernel.org> (raw)
In-Reply-To: <20210301185642.163396-1-gonsolo@gmail.com>
Em Mon, Mar 01, 2021 at 07:56:42PM +0100, Gon Solo escreveu:
> From: Andreas Wendleder <andreas.wendleder@gmail.com>
>
> Remove generated directory tools/perf/arch/x86/include/generated.
Thanks applied.
There is one more, consider fixing it too:
$ make -C tools/perf clean
make: Entering directory '/home/acme/git/perf/tools/perf'
CLEAN x86
CLEAN libtraceevent
CLEAN libapi
CLEAN libbpf
CLEAN libsubcmd
CLEAN libperf
CLEAN fixdep
CLEAN feature-detect
CLEAN python
CLEAN bpf-skel
CLEAN core-objs
CLEAN core-progs
CLEAN core-gen
CLEAN Documentation
make: Leaving directory '/home/acme/git/perf/tools/perf'
$ find tools/perf -name generated
tools/perf/trace/beauty/generated
$
- Arnaldo
> Signed-off-by: Andreas Wendleder <andreas.wendleder@gmail.com>
> ---
> tools/perf/arch/x86/Makefile | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/tools/perf/arch/x86/Makefile b/tools/perf/arch/x86/Makefile
> index 8cc6642fce7a..5a9f9a7bf07d 100644
> --- a/tools/perf/arch/x86/Makefile
> +++ b/tools/perf/arch/x86/Makefile
> @@ -10,10 +10,11 @@ PERF_HAVE_JITDUMP := 1
> # Syscall table generation
> #
>
> -out := $(OUTPUT)arch/x86/include/generated/asm
> -header := $(out)/syscalls_64.c
> -sys := $(srctree)/tools/perf/arch/x86/entry/syscalls
> -systbl := $(sys)/syscalltbl.sh
> +generated := $(OUTPUT)arch/x86/include/generated
> +out := $(generated)/asm
> +header := $(out)/syscalls_64.c
> +sys := $(srctree)/tools/perf/arch/x86/entry/syscalls
> +systbl := $(sys)/syscalltbl.sh
>
> # Create output directory if not already present
> _dummy := $(shell [ -d '$(out)' ] || mkdir -p '$(out)')
> @@ -22,6 +23,6 @@ $(header): $(sys)/syscall_64.tbl $(systbl)
> $(Q)$(SHELL) '$(systbl)' $(sys)/syscall_64.tbl 'x86_64' > $@
>
> clean::
> - $(call QUIET_CLEAN, x86) $(RM) $(header)
> + $(call QUIET_CLEAN, x86) $(RM) -r $(header) $(generated)
>
> archheaders: $(header)
> --
> 2.27.0
>
--
- Arnaldo
prev parent reply other threads:[~2021-03-02 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 18:56 [PATCH] Perf: Clean generated directory Gon Solo
2021-03-02 12:23 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD4uLRARSI16b9eJ@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andreas.wendleder@gmail.com \
--cc=gonsolo@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.