From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: kajoljain <kjain@linux.ibm.com>
Cc: "Paul A. Clarke" <pc@us.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
mpe@ellerman.id.au, ananth@linux.vnet.ibm.com,
maddy@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com,
sukadev@linux.ibm.com
Subject: Re: [PATCH] [perf] powerpc: Remove unsupported metrics
Date: Tue, 2 Mar 2021 09:44:47 -0300 [thread overview]
Message-ID: <YD4zP98AxJ2Enf0Y@kernel.org> (raw)
In-Reply-To: <262409c9-11e2-3327-e645-604c9d300a2d@linux.ibm.com>
Em Fri, Feb 26, 2021 at 11:03:11AM +0530, kajoljain escreveu:
>
>
> On 2/24/21 11:44 PM, Paul A. Clarke wrote:
> > Several metrics are defined based on unsupported / non-existent
> > events, and silently discarded. Remove them for good code hygiene
> > and to avoid confusion.
> >
>
> Hi Paul,
> Thanks for the patch. Changes looks good to me.
>
> Reviewed-by: Kajol Jain<kjain@linux.ibm.com>
Thanks, applied to perf/core.
- Arnaldo
> Thanks,
> Kajol Jain
>
> > Signed-off-by: Paul A. Clarke <pc@us.ibm.com>
> > ---
> > .../arch/powerpc/power9/metrics.json | 132 ------------------
> > 1 file changed, 132 deletions(-)
> >
> > diff --git a/tools/perf/pmu-events/arch/powerpc/power9/metrics.json b/tools/perf/pmu-events/arch/powerpc/power9/metrics.json
> > index f8784c608479..140402d2855f 100644
> > --- a/tools/perf/pmu-events/arch/powerpc/power9/metrics.json
> > +++ b/tools/perf/pmu-events/arch/powerpc/power9/metrics.json
> > @@ -1209,156 +1209,24 @@
> > "MetricGroup": "instruction_stats_percent_per_ref",
> > "MetricName": "inst_from_rmem_percent"
> > },
> > - {
> > - "BriefDescription": "%L2 Modified CO Cache read Utilization (4 pclks per disp attempt)",
> > - "MetricExpr": "((PM_L2_CASTOUT_MOD/2)*4)/ PM_RUN_CYC * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_co_m_rd_util"
> > - },
> > - {
> > - "BriefDescription": "L2 dcache invalidates per run inst (per core)",
> > - "MetricExpr": "(PM_L2_DC_INV / 2) / PM_RUN_INST_CMPL * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_dc_inv_rate_percent"
> > - },
> > {
> > "BriefDescription": "Demand load misses as a % of L2 LD dispatches (per thread)",
> > "MetricExpr": "PM_L1_DCACHE_RELOAD_VALID / (PM_L2_LD / 2) * 100",
> > "MetricGroup": "l2_stats",
> > "MetricName": "l2_dem_ld_disp_percent"
> > },
> > - {
> > - "BriefDescription": "L2 Icache invalidates per run inst (per core)",
> > - "MetricExpr": "(PM_L2_IC_INV / 2) / PM_RUN_INST_CMPL * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_ic_inv_rate_percent"
> > - },
> > - {
> > - "BriefDescription": "L2 Inst misses as a % of total L2 Inst dispatches (per thread)",
> > - "MetricExpr": "PM_L2_INST_MISS / PM_L2_INST * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_inst_miss_ratio_percent"
> > - },
> > - {
> > - "BriefDescription": "Average number of cycles between L2 Load hits",
> > - "MetricExpr": "(PM_L2_LD_HIT / PM_RUN_CYC) / 2",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_ld_hit_frequency"
> > - },
> > - {
> > - "BriefDescription": "Average number of cycles between L2 Load misses",
> > - "MetricExpr": "(PM_L2_LD_MISS / PM_RUN_CYC) / 2",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_ld_miss_frequency"
> > - },
> > - {
> > - "BriefDescription": "L2 Load misses as a % of total L2 Load dispatches (per thread)",
> > - "MetricExpr": "PM_L2_LD_MISS / PM_L2_LD * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_ld_miss_ratio_percent"
> > - },
> > - {
> > - "BriefDescription": "% L2 load disp attempts Cache read Utilization (4 pclks per disp attempt)",
> > - "MetricExpr": "((PM_L2_RCLD_DISP/2)*4)/ PM_RUN_CYC * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_ld_rd_util"
> > - },
> > - {
> > - "BriefDescription": "L2 load misses that require a cache write (4 pclks per disp attempt) % of pclks",
> > - "MetricExpr": "((( PM_L2_LD_DISP - PM_L2_LD_HIT)/2)*4)/ PM_RUN_CYC * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_ldmiss_wr_util"
> > - },
> > - {
> > - "BriefDescription": "L2 local pump prediction success",
> > - "MetricExpr": "PM_L2_LOC_GUESS_CORRECT / (PM_L2_LOC_GUESS_CORRECT + PM_L2_LOC_GUESS_WRONG) * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_local_pred_correct_percent"
> > - },
> > - {
> > - "BriefDescription": "L2 COs that were in M,Me,Mu state as a % of all L2 COs",
> > - "MetricExpr": "PM_L2_CASTOUT_MOD / (PM_L2_CASTOUT_MOD + PM_L2_CASTOUT_SHR) * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_mod_co_percent"
> > - },
> > - {
> > - "BriefDescription": "% of L2 Load RC dispatch atampts that failed because of address collisions and cclass conflicts",
> > - "MetricExpr": "(PM_L2_RCLD_DISP_FAIL_ADDR )/ PM_L2_RCLD_DISP * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_rc_ld_disp_addr_fail_percent"
> > - },
> > - {
> > - "BriefDescription": "% of L2 Load RC dispatch attempts that failed",
> > - "MetricExpr": "(PM_L2_RCLD_DISP_FAIL_ADDR + PM_L2_RCLD_DISP_FAIL_OTHER)/ PM_L2_RCLD_DISP * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_rc_ld_disp_fail_percent"
> > - },
> > - {
> > - "BriefDescription": "% of L2 Store RC dispatch atampts that failed because of address collisions and cclass conflicts",
> > - "MetricExpr": "PM_L2_RCST_DISP_FAIL_ADDR / PM_L2_RCST_DISP * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_rc_st_disp_addr_fail_percent"
> > - },
> > - {
> > - "BriefDescription": "% of L2 Store RC dispatch attempts that failed",
> > - "MetricExpr": "(PM_L2_RCST_DISP_FAIL_ADDR + PM_L2_RCST_DISP_FAIL_OTHER)/ PM_L2_RCST_DISP * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_rc_st_disp_fail_percent"
> > - },
> > - {
> > - "BriefDescription": "L2 Cache Read Utilization (per core)",
> > - "MetricExpr": "(((PM_L2_RCLD_DISP/2)*4)/ PM_RUN_CYC * 100) + (((PM_L2_RCST_DISP/2)*4)/PM_RUN_CYC * 100) + (((PM_L2_CASTOUT_MOD/2)*4)/PM_RUN_CYC * 100)",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_rd_util_percent"
> > - },
> > - {
> > - "BriefDescription": "L2 COs that were in T,Te,Si,S state as a % of all L2 COs",
> > - "MetricExpr": "PM_L2_CASTOUT_SHR / (PM_L2_CASTOUT_MOD + PM_L2_CASTOUT_SHR) * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_shr_co_percent"
> > - },
> > {
> > "BriefDescription": "L2 Store misses as a % of total L2 Store dispatches (per thread)",
> > "MetricExpr": "PM_L2_ST_MISS / PM_L2_ST * 100",
> > "MetricGroup": "l2_stats",
> > "MetricName": "l2_st_miss_ratio_percent"
> > },
> > - {
> > - "BriefDescription": "% L2 store disp attempts Cache read Utilization (4 pclks per disp attempt)",
> > - "MetricExpr": "((PM_L2_RCST_DISP/2)*4) / PM_RUN_CYC * 100",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_st_rd_util"
> > - },
> > {
> > "BriefDescription": "L2 stores that require a cache write (4 pclks per disp attempt) % of pclks",
> > "MetricExpr": "((PM_L2_ST_DISP/2)*4) / PM_RUN_CYC * 100",
> > "MetricGroup": "l2_stats",
> > "MetricName": "l2_st_wr_util"
> > },
> > - {
> > - "BriefDescription": "L2 Cache Write Utilization (per core)",
> > - "MetricExpr": "((((PM_L2_LD_DISP - PM_L2_LD_HIT)/2)*4) / PM_RUN_CYC * 100) + (((PM_L2_ST_DISP/2)*4) / PM_RUN_CYC * 100)",
> > - "MetricGroup": "l2_stats",
> > - "MetricName": "l2_wr_util_percent"
> > - },
> > - {
> > - "BriefDescription": "Average number of cycles between L3 Load hits",
> > - "MetricExpr": "(PM_L3_LD_HIT / PM_RUN_CYC) / 2",
> > - "MetricGroup": "l3_stats",
> > - "MetricName": "l3_ld_hit_frequency"
> > - },
> > - {
> > - "BriefDescription": "Average number of cycles between L3 Load misses",
> > - "MetricExpr": "(PM_L3_LD_MISS / PM_RUN_CYC) / 2",
> > - "MetricGroup": "l3_stats",
> > - "MetricName": "l3_ld_miss_frequency"
> > - },
> > - {
> > - "BriefDescription": "Average number of Write-in machines used. 1 of 8 WI machines is sampled every L3 cycle",
> > - "MetricExpr": "(PM_L3_WI_USAGE / PM_RUN_CYC) * 8",
> > - "MetricGroup": "l3_stats",
> > - "MetricName": "l3_wi_usage"
> > - },
> > {
> > "BriefDescription": "Average icache miss latency",
> > "MetricExpr": "PM_IC_DEMAND_CYC / PM_IC_DEMAND_REQ",
> >
--
- Arnaldo
prev parent reply other threads:[~2021-03-03 5:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 18:14 [PATCH] [perf] powerpc: Remove unsupported metrics Paul A. Clarke
2021-02-26 5:33 ` kajoljain
2021-03-02 12:44 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD4zP98AxJ2Enf0Y@kernel.org \
--to=acme@kernel.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=pc@us.ibm.com \
--cc=sukadev@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.