Re: [PATCH 5.10 000/658] 5.10.20-rc3 review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Mar 02, 2021 at 08:03:15PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 02, 2021 at 10:44:15AM -0800, Guenter Roeck wrote:
> > On 3/2/21 4:38 AM, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.20 release.
> > > There are 658 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Thu, 04 Mar 2021 12:32:41 +0000.
> > > Anything received after that time might be too late.
> > > 
> > 
> > Building arm:allmodconfig ... failed
> > --------------
> > Error log:
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c: In function 'mtk_aal_config':
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:183:54: error: 'struct mtk_ddp_comp' has no member named 'dev'
> >   183 |  struct mtk_ddp_comp_dev *priv = dev_get_drvdata(comp->dev);
> >       |                                                      ^~
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:185:44: error: dereferencing pointer to incomplete type 'struct mtk_ddp_comp_dev'
> >   185 |  mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE);
> >       |                                            ^~
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:185:2: error: too many arguments to function 'mtk_ddp_write'
> >   185 |  mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE);
> >       |  ^~~~~~~~~~~~~
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:89:6: note: declared here
> >    89 | void mtk_ddp_write(struct cmdq_pkt *cmdq_pkt, unsigned int value,
> >       |      ^~~~~~~~~~~~~
> > make[5]: *** [drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.o] Error 1
> > make[4]: *** [drivers/gpu/drm/mediatek] Error 2
> > 
> > ---
> > Building arm64:allmodconfig ... failed
> > --------------
> > Error log:
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c: In function 'mtk_aal_config':
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:183:54: error: 'struct mtk_ddp_comp' has no member named 'dev'
> >   183 |  struct mtk_ddp_comp_dev *priv = dev_get_drvdata(comp->dev);
> >       |                                                      ^~
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:185:44: error: dereferencing pointer to incomplete type 'struct mtk_ddp_comp_dev'
> >   185 |  mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE);
> >       |                                            ^~
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:185:2: error: too many arguments to function 'mtk_ddp_write'
> >   185 |  mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv->regs, DISP_AAL_SIZE);
> >       |  ^~~~~~~~~~~~~
> > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c:89:6: note: declared here
> >    89 | void mtk_ddp_write(struct cmdq_pkt *cmdq_pkt, unsigned int value,
> >       |      ^~~~~~~~~~~~~
> > make[5]: *** [drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.o] Error 1
> > 
> > 
> > The same problem also affects v5.11.y.
> > 
> > Am I missing something here ? Why do I see that problem ? It seems to be very basic.
> 
> You aren't the only one, I got an off-list response that this was seen
> as well.  Let me dig into it...

Found it, am dropping the offending patch now.  Should also affect
5.11.y too.

Looks like I'll do a whole new round of -rcs for all queues now, this
has been a rough cycle...

greg k-h