From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-usb-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 4D2B0C433E6
	for <linux-usb@archiver.kernel.org>; Sat, 20 Feb 2021 07:00:43 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 1E18864EB8
	for <linux-usb@archiver.kernel.org>; Sat, 20 Feb 2021 07:00:43 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229771AbhBTG7r (ORCPT <rfc822;linux-usb@archiver.kernel.org>);
        Sat, 20 Feb 2021 01:59:47 -0500
Received: from mail.kernel.org ([198.145.29.99]:58336 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229667AbhBTG7m (ORCPT <rfc822;linux-usb@vger.kernel.org>);
        Sat, 20 Feb 2021 01:59:42 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2058264EB4;
        Sat, 20 Feb 2021 06:58:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1613804336;
        bh=W1cYIHNaXh/nr20qqfSDTfd2Iv4fCjT8Ss8/4lE3VYs=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=KZdXA18y/2OWnEKXxLWXpb5jSa1YHTvtdYLj6n+4diBQd/bxBiubSY6eL4+mcGfsU
         eZuVh60YqLRnMqVNf7EGSi69oAr8wxc+2EwP/TMC6eMeReYVkIm95vcsbQsxl26APE
         LmNvXe/TlxHiOTdvL/8Bna44ewttdgJB2R6CqmoU=
Date:   Sat, 20 Feb 2021 07:58:53 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc:     Shuah Khan <skhan@linuxfoundation.org>,
        Valentina Manea <valentina.manea.m@gmail.com>,
        Shuah Khan <shuah@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] usb: usbip: serialize attach/detach operations
Message-ID: <YDCzLfhawx4u28dd@kroah.com>
References: <20210219094744.3577-1-penguin-kernel@I-love.SAKURA.ne.jp>
 <20210219150832.4701-1-penguin-kernel@I-love.SAKURA.ne.jp>
 <YC/fF0c7PA3ndTPv@kroah.com>
 <68fe3981-27d2-1f8d-17c6-9cb773382e66@linuxfoundation.org>
 <f8110365-767d-6aa4-ff9e-3ab8380c0919@i-love.sakura.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f8110365-767d-6aa4-ff9e-3ab8380c0919@i-love.sakura.ne.jp>
Precedence: bulk
List-ID: <linux-usb.vger.kernel.org>
X-Mailing-List: linux-usb@vger.kernel.org

On Sat, Feb 20, 2021 at 10:10:03AM +0900, Tetsuo Handa wrote:
> On 2021/02/20 1:00, Shuah Khan wrote:
> > On 2/19/21 8:53 AM, Greg Kroah-Hartman wrote:
> >> What changed from v1?  Why isn't that info below the --- line?
> >>
> >> Please do a v3 with that fixed up.
> >>
> > 
> > +1 on this.
> 
> v2 fixed the PTR_ERR() access which was reported in v1 as below.

<snip>

Great, please add that to the v3 patch when you resubmit it.

> 
>   On 2021/02/20 2:10, Julia Lawall wrote:
>   > From: kernel test robot <lkp@intel.com>
>   > 
>   > PTR_ERR should access the value just tested by IS_ERR
>   > 
>   > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>   > 
>   > CC: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>   > Reported-by: kernel test robot <lkp@intel.com>
>   > Signed-off-by: kernel test robot <lkp@intel.com>
>   > Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> 
> > 
> > Also please run the usbip test on your changes:
> > tools/testing/selftests/drivers/usb/usbip/usbip_test.sh
> 
> Too much requirements for me to run that test. I'm not a user of your module.

It should be self-contained, what requirements do you see that you do
not have?

thanks,

greg k-h