From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E6BC433DB for ; Mon, 22 Feb 2021 17:02:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AAB6614A7 for ; Mon, 22 Feb 2021 17:02:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AAB6614A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E111389D8D; Mon, 22 Feb 2021 17:02:09 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E77C89D8D for ; Mon, 22 Feb 2021 17:02:08 +0000 (UTC) IronPort-SDR: zYO+Wg7/J4qRXz5OEMPLxLj3D7O0f9siHr3xuaDMhJJwcSWAdWKh8E9o35JO2sCEeMUtEpQZjw PpWrgFh9EFSQ== X-IronPort-AV: E=McAfee;i="6000,8403,9903"; a="172169772" X-IronPort-AV: E=Sophos;i="5.81,197,1610438400"; d="scan'208";a="172169772" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 09:02:07 -0800 IronPort-SDR: Irnvx2g8ua66P0Lh+MFTFjJIBYHAHoa53CYFrX+8sB2IVxhjxHB+t28byNKz90ppa7tF98pXbT aN8hmrENtGNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,197,1610438400"; d="scan'208";a="389926095" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga008.fm.intel.com with SMTP; 22 Feb 2021 09:02:04 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 22 Feb 2021 19:02:03 +0200 Date: Mon, 22 Feb 2021 19:02:03 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Wayne Lin Subject: Re: [PATCH 1/2] drm/dp_mst: Revise broadcast msg lct & lcr Message-ID: References: <20210222040027.23505-1-Wayne.Lin@amd.com> <20210222040027.23505-2-Wayne.Lin@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210222040027.23505-2-Wayne.Lin@amd.com> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eryk.brol@amd.com, qingqing.zhuo@amd.com, stable@vger.kernel.org, jerry.zuo@amd.com, dri-devel@lists.freedesktop.org, Nicholas.Kazlauskas@amd.com Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 22, 2021 at 12:00:26PM +0800, Wayne Lin wrote: > [Why & How] > According to DP spec, broadcast message LCT equals to 1 and LCR equals > to 6. Current implementation is incorrect. Fix it. > = > Signed-off-by: Wayne Lin > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_= dp_mst_topology.c > index 17dbed0a9800..713ef3b42054 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2727,8 +2727,14 @@ static int set_hdr_from_dst_qlock(struct drm_dp_si= deband_msg_hdr *hdr, > else > hdr->broadcast =3D 0; > hdr->path_msg =3D txmsg->path_msg; > - hdr->lct =3D mstb->lct; > - hdr->lcr =3D mstb->lct - 1; > + if (hdr->broadcast) { > + hdr->lct =3D 1; > + hdr->lcr =3D 6; > + } else { > + hdr->lct =3D mstb->lct; > + hdr->lcr =3D mstb->lct - 1; > + } > + > if (mstb->lct > 1) > memcpy(hdr->rad, mstb->rad, mstb->lct / 2); We should also do something about RAD no? > = > -- = > 2.17.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 145F7C433E0 for ; Mon, 22 Feb 2021 17:04:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB73764F02 for ; Mon, 22 Feb 2021 17:04:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230037AbhBVRE1 (ORCPT ); Mon, 22 Feb 2021 12:04:27 -0500 Received: from mga04.intel.com ([192.55.52.120]:61346 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbhBVREV (ORCPT ); Mon, 22 Feb 2021 12:04:21 -0500 IronPort-SDR: K+Nu0qqTu6YztLpBa+RKDdaYGNBwFfIDq/EM0bkLMAIFL0tG0G4VThspjAD7y8zCGiPcfJ1Ss+ ia1ug8mNcHAw== X-IronPort-AV: E=McAfee;i="6000,8403,9903"; a="182018145" X-IronPort-AV: E=Sophos;i="5.81,197,1610438400"; d="scan'208";a="182018145" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 09:02:09 -0800 IronPort-SDR: Irnvx2g8ua66P0Lh+MFTFjJIBYHAHoa53CYFrX+8sB2IVxhjxHB+t28byNKz90ppa7tF98pXbT aN8hmrENtGNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,197,1610438400"; d="scan'208";a="389926095" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga008.fm.intel.com with SMTP; 22 Feb 2021 09:02:04 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 22 Feb 2021 19:02:03 +0200 Date: Mon, 22 Feb 2021 19:02:03 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Wayne Lin Cc: dri-devel@lists.freedesktop.org, eryk.brol@amd.com, qingqing.zhuo@amd.com, stable@vger.kernel.org, jerry.zuo@amd.com, Nicholas.Kazlauskas@amd.com Subject: Re: [PATCH 1/2] drm/dp_mst: Revise broadcast msg lct & lcr Message-ID: References: <20210222040027.23505-1-Wayne.Lin@amd.com> <20210222040027.23505-2-Wayne.Lin@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210222040027.23505-2-Wayne.Lin@amd.com> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Feb 22, 2021 at 12:00:26PM +0800, Wayne Lin wrote: > [Why & How] > According to DP spec, broadcast message LCT equals to 1 and LCR equals > to 6. Current implementation is incorrect. Fix it. > > Signed-off-by: Wayne Lin > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 17dbed0a9800..713ef3b42054 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2727,8 +2727,14 @@ static int set_hdr_from_dst_qlock(struct drm_dp_sideband_msg_hdr *hdr, > else > hdr->broadcast = 0; > hdr->path_msg = txmsg->path_msg; > - hdr->lct = mstb->lct; > - hdr->lcr = mstb->lct - 1; > + if (hdr->broadcast) { > + hdr->lct = 1; > + hdr->lcr = 6; > + } else { > + hdr->lct = mstb->lct; > + hdr->lcr = mstb->lct - 1; > + } > + > if (mstb->lct > 1) > memcpy(hdr->rad, mstb->rad, mstb->lct / 2); We should also do something about RAD no? > > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel