From: Greg KH <gregkh@linuxfoundation.org>
To: SeongJae Park <sjpark@amazon.com>
Cc: sashal@kernel.org, aams@amazon.com, markubo@amazon.com,
linux-kernel@vger.kernel.org,
"# 4 . 4 . y" <stable@vger.kernel.org>,
David Vrabel <david.vrabel@citrix.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: Please apply "xen-netback: delete NAPI instance when queue fails to initialize" to v4.4.y
Date: Wed, 24 Feb 2021 18:21:09 +0100 [thread overview]
Message-ID: <YDaLBcj5DJrSWXqU@kroah.com> (raw)
In-Reply-To: <20210224170356.20697-1-sjpark@amazon.com>
On Wed, Feb 24, 2021 at 06:03:56PM +0100, SeongJae Park wrote:
> This is a request for merge of upstream commit 4a658527271b ("xen-netback:
> delete NAPI instance when queue fails to initialize") on v4.4.y tree.
>
> If 'xenvif_connect()' fails after successful 'netif_napi_add()', the napi is
> not cleaned up. Because 'create_queues()' frees the queues in its error
> handling code, if the 'xenvif_free()' is called for the vif, use-after-free
> occurs. The upstream commit fixes the problem by cleaning up the napi in the
> 'xenvif_connect()'.
>
> Attaching the original patch below for your convenience.
The original patch does not apply cleanly.
> Tested-by: Markus Boehme <markubo@amazon.de>
What was tested?
I backported the patch, but next time, please provide the patch that
will work properly.
greg k-h
next prev parent reply other threads:[~2021-02-24 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 17:03 Please apply "xen-netback: delete NAPI instance when queue fails to initialize" to v4.4.y SeongJae Park
2021-02-24 17:21 ` Greg KH [this message]
2021-02-24 17:47 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDaLBcj5DJrSWXqU@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aams@amazon.com \
--cc=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markubo@amazon.com \
--cc=sashal@kernel.org \
--cc=sjpark@amazon.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.