From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: Yaron Wittenstein <yaron.wittenstein@gmail.com>, git@vger.kernel.org
Subject: Re: [QUESTION] Tracking HEAD changes?
Date: Thu, 25 Feb 2021 06:36:54 +0100 [thread overview]
Message-ID: <YDc3dinQ37FY8fhD@ncase> (raw)
In-Reply-To: <YDa/EupbrNa62r+D@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]
On Wed, Feb 24, 2021 at 04:03:14PM -0500, Jeff King wrote:
> On Wed, Feb 24, 2021 at 10:21:55PM +0200, Yaron Wittenstein wrote:
>
> > That indeed seems to do the trick.
> > I've done a little experiment and saw that when doing git reset the
> > hook gets called.
> >
> > However, when switching branches the hook doesn't execute :(
> >
> > I don't understand if it's intentional, since when I've moved to a new
> > branch HEAD pointed to another commit id.
> > The only workaround I see here is using the post-checkout hook in addition.
>
> Hmm, I would have thought that the branch switch would trigger the hooks
> because they're updating HEAD. I wonder if that is a bug (or lack of
> feature :) ) in the transaction hooks, or something Patrick did
> intentionally.
>
> -Peff
It was done semi-intentionally, or at least with the knowledge that
symrefs aren't covered. This is mostly because they're not covered by
the reference transaction mechanism itself.
But this again reminds me that I still have to update the documentation
of the hook to at least make it more explicit what's currently covered
and what's not.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-02-25 5:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 9:12 [QUESTION] Tracking HEAD changes? Yaron Wittenstein
2021-02-23 0:38 ` Jeff King
2021-02-23 20:42 ` Jeff King
2021-02-24 20:21 ` Yaron Wittenstein
2021-02-24 21:03 ` Jeff King
2021-02-25 5:36 ` Patrick Steinhardt [this message]
2021-02-25 6:01 ` Yaron Wittenstein
2021-02-25 6:27 ` Patrick Steinhardt
2021-02-25 7:13 ` Junio C Hamano
2021-02-25 7:28 ` Patrick Steinhardt
2021-02-25 7:50 ` Yaron Wittenstein
2021-02-26 5:59 ` Jeff King
2021-02-26 20:58 ` Yaron Wittenstein
2021-03-01 9:03 ` Jeff King
2021-03-01 10:02 ` Yaron Wittenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDc3dinQ37FY8fhD@ncase \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=yaron.wittenstein@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.