All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
Cc: stable@vger.kernel.org, netdev@vger.kernel.org,
	jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
	daichi1.fukui@toshiba.co.jp, nobuhiro1.iwamatsu@toshiba.co.jp,
	Corinna Vinschen <vinschen@redhat.com>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Aaron Brown <aaron.f.brown@intel.com>
Subject: Re: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message
Date: Thu, 25 Feb 2021 09:17:54 +0100	[thread overview]
Message-ID: <YDddMnkytDS76mYN@kroah.com> (raw)
In-Reply-To: <20210225005406.530767-1-punit1.agrawal@toshiba.co.jp>

On Thu, Feb 25, 2021 at 09:54:06AM +0900, Punit Agrawal wrote:
> From: Corinna Vinschen <vinschen@redhat.com>
> 
> commit 2643e6e90210e16c978919617170089b7c2164f7 upstream
> 
> TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP
> every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000
> secs on 80576 (45 bit SYSTIM).
> 
> This wrap event sets the TSICR.SysWrap bit unconditionally.
> 
> However, checking TSIM at interrupt time shows that this event does not
> actually cause the interrupt.  Rather, it's just bycatch while the
> actual interrupt is caused by, for instance, TSICR.TXTS.
> 
> The conclusion is that the SYS WRAP is actually expected, so the
> "unexpected SYS WRAP" message is entirely bogus and just helps to
> confuse users.  Drop it.
> 
> Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
> Acked-by: Jacob Keller <jacob.e.keller@intel.com>
> Tested-by: Aaron Brown <aaron.f.brown@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> [ Due to confusion about stable rules for networking the request was
> mistakenly sent to netdev only[0]. Apologies if you're seeing this
> again. ]

No signed-off-by: from you?  :(


  reply	other threads:[~2021-02-25  8:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25  0:54 [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message Punit Agrawal
2021-02-25  8:17 ` Greg KH [this message]
2021-03-17  0:38   ` Punit Agrawal
  -- strict thread matches above, loose matches on Subject: below --
2021-02-10  1:34 Punit Agrawal
2021-02-10  1:46 ` Keller, Jacob E
2021-02-24  2:28   ` Punit Agrawal
     [not found]     ` <20210224085126.45af7b68@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-02-25  0:44       ` Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDddMnkytDS76mYN@kroah.com \
    --to=greg@kroah.com \
    --cc=aaron.f.brown@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=daichi1.fukui@toshiba.co.jp \
    --cc=jacob.e.keller@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=punit1.agrawal@toshiba.co.jp \
    --cc=stable@vger.kernel.org \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.