From: Andrew Lunn <andrew@lunn.ch>
To: Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org,
f.fainelli@gmail.com, linux-imx@nxp.com, netdev@vger.kernel.org
Subject: Re: [RFC V2 net-next 1/3] net: stmmac: add clocks management for gmac driver
Date: Thu, 25 Feb 2021 14:31:12 +0100 [thread overview]
Message-ID: <YDemoDbVIfblk2u+@lunn.ch> (raw)
In-Reply-To: <20210225115050.23971-2-qiangqing.zhang@nxp.com>
> @@ -248,9 +296,15 @@ static int stmmac_mdio_write(struct mii_bus *bus, int phyaddr, int phyreg,
> unsigned int mii_address = priv->hw->mii.addr;
> unsigned int mii_data = priv->hw->mii.data;
> u32 value = MII_BUSY;
> - int data = phydata;
> + int ret, data = phydata;
> u32 v;
Reverse Christmass tree.
Otherwise this looks good.
Andrew
next prev parent reply other threads:[~2021-02-25 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 11:50 [RFC V2 net-next 0/3] net: stmmac: implement clocks management Joakim Zhang
2021-02-25 11:50 ` [RFC V2 net-next 1/3] net: stmmac: add clocks management for gmac driver Joakim Zhang
2021-02-25 13:31 ` Andrew Lunn [this message]
2021-02-25 11:50 ` [RFC V2 net-next 2/3] net: stmmac: add platform level clocks management Joakim Zhang
2021-02-25 11:50 ` [RFC V2 net-next 3/3] net: stmmac: add platform level clocks management for i.MX Joakim Zhang
2021-02-26 1:24 ` [RFC V2 net-next 0/3] net: stmmac: implement clocks management Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDemoDbVIfblk2u+@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.