From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 333D9C433E6 for ; Fri, 26 Feb 2021 07:32:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6D3264EEE for ; Fri, 26 Feb 2021 07:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230112AbhBZHc0 (ORCPT ); Fri, 26 Feb 2021 02:32:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:43518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbhBZHcX (ORCPT ); Fri, 26 Feb 2021 02:32:23 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3766A64ED3; Fri, 26 Feb 2021 07:31:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614324702; bh=ND2aNeSDF+CdZU//MneX68fHcP77aarQea98G/sjog8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kyTVO/5zoV3mCcbKZbeXmldvDRSAWZfPiUe27bW63bx306jI3XR4sLsfLkzbdwxIX dShMl/9mAMELUcii6lq8l3MgeKRu5uZjzVAqUurR0Mz2a8GpaNMH6U2CvFQSaq4AoV hTeDK0LeCDH5mt+3MWxHjJtPd1gWo9nS+mh/+2sQ= Date: Fri, 26 Feb 2021 08:31:39 +0100 From: Greg KH To: Sumit Garg Cc: Daniel Thompson , kgdb-bugreport@lists.sourceforge.net, Andrew Morton , Masami Hiramatsu , Steven Rostedt , Jason Wessel , Douglas Anderson , Peter Zijlstra , stefan.saecherl@fau.de, qy15sije@cip.cs.fau.de, Linux Kernel Mailing List , stable Subject: Re: [PATCH] kgdb: Fix to kill breakpoints on initmem after boot Message-ID: References: <20210224081652.587785-1-sumit.garg@linaro.org> <20210225155607.634snzzq3w62kpkn@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 12:32:07PM +0530, Sumit Garg wrote: > + stable ML > > On Thu, 25 Feb 2021 at 21:26, Daniel Thompson > wrote: > > > > On Wed, Feb 24, 2021 at 01:46:52PM +0530, Sumit Garg wrote: > > > Currently breakpoints in kernel .init.text section are not handled > > > correctly while allowing to remove them even after corresponding pages > > > have been freed. > > > > > > Fix it via killing .init.text section breakpoints just prior to initmem > > > pages being freed. > > > > > > Suggested-by: Doug Anderson > > > Signed-off-by: Sumit Garg > > > > I saw Andrew has picked this one up. That's ok for me: > > Acked-by: Daniel Thompson > > > > I already enriched kgdbtest to cover this (and they pass) so I guess > > this is also: > > Tested-by: Daniel Thompson > > > > Thanks Daniel. > > > BTW this is not Cc:ed to stable and I do wonder if it crosses the > > threshold to be considered a fix rather than a feature. Normally I > > consider adding safety rails for kgdb to be a new feature but, in this > > case, the problem would easily ensnare an inexperienced developer who is > > doing nothing more than debugging their own driver (assuming they > > correctly marked their probe function as .init) so I think this weighs > > in favour of being a fix. > > > > Makes sense, Cc:ed stable. This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.