From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E13DC433DB for ; Sat, 27 Feb 2021 07:19:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4ACE64EC0 for ; Sat, 27 Feb 2021 07:19:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbhB0HTe (ORCPT ); Sat, 27 Feb 2021 02:19:34 -0500 Received: from muru.com ([72.249.23.125]:37738 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbhB0HTe (ORCPT ); Sat, 27 Feb 2021 02:19:34 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D60AA80CE; Sat, 27 Feb 2021 07:19:25 +0000 (UTC) Date: Sat, 27 Feb 2021 09:18:45 +0200 From: Tony Lindgren To: Tomi Valkeinen Cc: Sebastian Reichel , Laurent Pinchart , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , hns@goldelico.com, Sebastian Reichel Subject: Re: [PATCH v4 24/80] drm/omap: dsi: move TE GPIO handling into core Message-ID: References: <20201124124538.660710-1-tomi.valkeinen@ti.com> <20201124124538.660710-25-tomi.valkeinen@ti.com> <5b469566-c926-7e1f-8872-84774b96f389@ideasonboard.com> <4432cf2c-fe15-dab0-3034-789f6d711396@ideasonboard.com> <7c852efd-560a-4dbb-ed04-e4812b343a33@ideasonboard.com> <0eb62659-041d-d3bd-3803-4d562677dfbf@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0eb62659-041d-d3bd-3803-4d562677dfbf@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Tomi Valkeinen [210226 09:04]: > Hmm, if I read the code right, TE was not enabled at all before this patch. > And this patch enables it. So maybe TE has never worked with that panel? > > You could try changing the enable_te calls to pass false. > > Or with the upstream driver, comment out > > mipi_dsi_dcs_set_tear_on(ddata->dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK); Yup you're right that's it. Commenting it out in drivers/gpu/drm/panel/panel-dsi-cm.c makes the warnings go away. There are some BTA related comments in the old v3.0.8 based Android kernel for droid4 panel at [0], but I don't really follow what they mean. Maybe it's some ordering issue? Regards, Tony [0] https://github.com/NotKit/android_kernel_motorola_omap4-common/blob/hybris-11.0/drivers/video/omap2/displays/panel-mapphone.c From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431A6C433E0 for ; Sat, 27 Feb 2021 07:18:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB97664E7A for ; Sat, 27 Feb 2021 07:18:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB97664E7A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 443176E19C; Sat, 27 Feb 2021 07:18:57 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BC8A6E19C for ; Sat, 27 Feb 2021 07:18:56 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D60AA80CE; Sat, 27 Feb 2021 07:19:25 +0000 (UTC) Date: Sat, 27 Feb 2021 09:18:45 +0200 From: Tony Lindgren To: Tomi Valkeinen Subject: Re: [PATCH v4 24/80] drm/omap: dsi: move TE GPIO handling into core Message-ID: References: <20201124124538.660710-1-tomi.valkeinen@ti.com> <20201124124538.660710-25-tomi.valkeinen@ti.com> <5b469566-c926-7e1f-8872-84774b96f389@ideasonboard.com> <4432cf2c-fe15-dab0-3034-789f6d711396@ideasonboard.com> <7c852efd-560a-4dbb-ed04-e4812b343a33@ideasonboard.com> <0eb62659-041d-d3bd-3803-4d562677dfbf@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0eb62659-041d-d3bd-3803-4d562677dfbf@ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hns@goldelico.com, Sekhar Nori , Sebastian Reichel , dri-devel@lists.freedesktop.org, Sebastian Reichel , Laurent Pinchart , linux-omap@vger.kernel.org, Nikhil Devshatwar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Tomi Valkeinen [210226 09:04]: > Hmm, if I read the code right, TE was not enabled at all before this patch. > And this patch enables it. So maybe TE has never worked with that panel? > > You could try changing the enable_te calls to pass false. > > Or with the upstream driver, comment out > > mipi_dsi_dcs_set_tear_on(ddata->dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK); Yup you're right that's it. Commenting it out in drivers/gpu/drm/panel/panel-dsi-cm.c makes the warnings go away. There are some BTA related comments in the old v3.0.8 based Android kernel for droid4 panel at [0], but I don't really follow what they mean. Maybe it's some ordering issue? Regards, Tony [0] https://github.com/NotKit/android_kernel_motorola_omap4-common/blob/hybris-11.0/drivers/video/omap2/displays/panel-mapphone.c _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel