From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C53C433DB for ; Sun, 28 Feb 2021 05:01:12 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C46FE64E38 for ; Sun, 28 Feb 2021 05:01:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C46FE64E38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lGECc-0006MD-CO; Sun, 28 Feb 2021 05:01:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGECb-0006M6-9j for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Feb 2021 05:01:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+c6qGt/m7SehmWAD/KWO+4gdk8gn2h3vvPF+OSXyG5s=; b=Tfmz7S2u/F3Fb6ByfPEdsJp8+h hFT9b3WZNszwGpEYYFnf3TGwPxFJP1dBOA0qlhafbzdB+HH9f5xg1hQURPgPwrJWMjx15mMr8dkm6 LpWcP5sNsdT5cSE4+5hITXkZjE7TNMOys2cqQcmOG+yE8/v/fU/085wZtg+PJ8480GTk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+c6qGt/m7SehmWAD/KWO+4gdk8gn2h3vvPF+OSXyG5s=; b=IbWeJ2GCydtfNTyUs99tNyMjt/ uoLeS4IFklbqh8LOOSZsfmvuTAePdEhVA3LZg7Ayzq2sclA/rzZ6aqAy6hG5RacmWzvjZzyVH4tpE ejejdRQ2enIxf1MPYh4NmpFOuVoq1IH6+8tew6mXJlWfOzunbe3wS3Y9Ums7yiThueiw=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lGECQ-0005nZ-RT for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Feb 2021 05:01:03 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 37AE664DD3; Sun, 28 Feb 2021 05:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614488453; bh=xQkMVcApfL3t8q7iWpH6mY+eJIkLuQ6BUnZPCj+gU5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BNyRoc/oZOtX9taoGATLjm2dxB0dYBTzztSuW5ONJGVMhWcto8jYx1xD2rtIzLmUd N2j5SVb40RAK7hqsrCSUkV0bJDe8w7Vd65nFTzpn3hBeW/py7LEw+bgoTGIa7TUzDP P511iZxGBzZZRn79KYKl/HzQ4KXlivbUr4nIDBwq6dkGkkaM1pDdaFUAW2ueh72ZsQ UknI/6Hbum4BrrSSKa4jmgC79g8cSvDGE7VBg1n7DJMLx72CtBs+Ncc5aOlLFxdQFS yFKlFCtlvUgmJwogKAUJQKAxhnKZtoA2u3PCrTYh3dzEU7TVRyXM2Xq6mcS9obXkP/ ZUSfeO5eeH9/A== Date: Sat, 27 Feb 2021 21:00:51 -0800 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20210224190313.GA144040@embeddedor> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1lGECQ-0005nZ-RT Subject: Re: [f2fs-dev] [PATCH][next] f2fs: Replace one-element array with flexible-array member X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDIvMjUsIENoYW8gWXUgd3JvdGU6Cj4gSGVsbG8sIEd1c3Rhdm8sCj4gCj4gT24gMjAyMS8y LzI1IDM6MDMsIEd1c3Rhdm8gQS4gUi4gU2lsdmEgd3JvdGU6Cj4gPiBUaGVyZSBpcyBhIHJlZ3Vs YXIgbmVlZCBpbiB0aGUga2VybmVsIHRvIHByb3ZpZGUgYSB3YXkgdG8gZGVjbGFyZSBoYXZpbmcK PiA+IGEgZHluYW1pY2FsbHkgc2l6ZWQgc2V0IG9mIHRyYWlsaW5nIGVsZW1lbnRzIGluIGEgc3Ry dWN0dXJlLiBLZXJuZWwgY29kZQo+ID4gc2hvdWxkIGFsd2F5cyB1c2Ug4oCcZmxleGlibGUgYXJy YXkgbWVtYmVyc+KAnVsxXSBmb3IgdGhlc2UgY2FzZXMuIFRoZSBvbGRlcgo+ID4gc3R5bGUgb2Yg b25lLWVsZW1lbnQgb3IgemVyby1sZW5ndGggYXJyYXlzIHNob3VsZCBubyBsb25nZXIgYmUgdXNl ZFsyXS4KPiAKPiBJIHByb3Bvc2FsIHRvIGRvIHRoZSBzaW1pbGFyIGNsZWFudXAsIGFuZCBJJ3Zl IG5vIG9iamVjdGlvbiBvbiBkb2luZyB0aGlzLgo+IAo+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L3BhdGNod29yay9wYXRjaC84Njk0NDAvCj4gCj4gTGV0J3MgYXNrIGZvciBKYWVnZXVrJyBvcGlu aW9uLgoKTWVyZ2VkLCB0aGFua3MuClRoaXMgbG9va3MgYmV0dGVyIHJlYXNvbiB0aGFuIGNvZGUg cmVhZGFiaWxpdHkuIDopCgo+IAo+ID4gCj4gPiBSZWZhY3RvciB0aGUgY29kZSBhY2NvcmRpbmcg dG8gdGhlIHVzZSBvZiBhIGZsZXhpYmxlLWFycmF5IG1lbWJlciBpbgo+ID4gc3RydWN0IGYyZnNf Y2hlY2twb2ludCwgaW5zdGVhZCBvZiBhIG9uZS1lbGVtZW50IGFycmF5cy4KPiA+IAo+ID4gTm90 aWNlIHRoYXQgYSB0ZW1wb3JhcnkgcG9pbnRlciB0byB2b2lkICcqdG1wX3B0cicgd2FzIHVzZWQg aW4gb3JkZXIgdG8KPiA+IGZpeCB0aGUgZm9sbG93aW5nIGVycm9ycyB3aGVuIHVzaW5nIGEgZmxl eGlibGUgYXJyYXkgaW5zdGVhZCBvZiBhIG9uZQo+ID4gZWxlbWVudCBhcnJheSBpbiBzdHJ1Y3Qg ZjJmc19jaGVja3BvaW50Ogo+ID4gCj4gPiAgICBDQyBbTV0gIGZzL2YyZnMvZGlyLm8KPiA+IElu IGZpbGUgaW5jbHVkZWQgZnJvbSBmcy9mMmZzL2Rpci5jOjEzOgo+ID4gZnMvZjJmcy9mMmZzLmg6 IEluIGZ1bmN0aW9uIOKAmF9fYml0bWFwX3B0cuKAmToKPiA+IGZzL2YyZnMvZjJmcy5oOjIyMjc6 NDA6IGVycm9yOiBpbnZhbGlkIHVzZSBvZiBmbGV4aWJsZSBhcnJheSBtZW1iZXIKPiA+ICAgMjIy NyB8ICAgcmV0dXJuICZja3B0LT5zaXRfbmF0X3ZlcnNpb25fYml0bWFwICsgb2Zmc2V0ICsgc2l6 ZW9mKF9fbGUzMik7Cj4gPiAgICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBeCj4gPiBmcy9mMmZzL2YyZnMuaDoyMjI3OjQ5OiBlcnJvcjogaW52YWxpZCB1c2Ug b2YgZmxleGlibGUgYXJyYXkgbWVtYmVyCj4gPiAgIDIyMjcgfCAgIHJldHVybiAmY2twdC0+c2l0 X25hdF92ZXJzaW9uX2JpdG1hcCArIG9mZnNldCArIHNpemVvZihfX2xlMzIpOwo+ID4gICAgICAg IHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgo+ID4g ZnMvZjJmcy9mMmZzLmg6MjIzODo0MDogZXJyb3I6IGludmFsaWQgdXNlIG9mIGZsZXhpYmxlIGFy cmF5IG1lbWJlcgo+ID4gICAyMjM4IHwgICByZXR1cm4gJmNrcHQtPnNpdF9uYXRfdmVyc2lvbl9i aXRtYXAgKyBvZmZzZXQ7Cj4gPiAgICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBeCj4gPiBtYWtlWzJdOiAqKiogW3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6Mjg3 OiBmcy9mMmZzL2Rpci5vXSBFcnJvciAxCj4gPiBtYWtlWzFdOiAqKiogW3NjcmlwdHMvTWFrZWZp bGUuYnVpbGQ6NTMwOiBmcy9mMmZzXSBFcnJvciAyCj4gPiBtYWtlOiAqKiogW01ha2VmaWxlOjE4 MTk6IGZzXSBFcnJvciAyCj4gPiAKPiA+IFsxXSBodHRwczovL2VuLndpa2lwZWRpYS5vcmcvd2lr aS9GbGV4aWJsZV9hcnJheV9tZW1iZXIKPiA+IFsyXSBodHRwczovL3d3dy5rZXJuZWwub3JnL2Rv Yy9odG1sL3Y1LjkvcHJvY2Vzcy9kZXByZWNhdGVkLmh0bWwjemVyby1sZW5ndGgtYW5kLW9uZS1l bGVtZW50LWFycmF5cwo+ID4gCj4gPiBMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vS1NQUC9saW51 eC9pc3N1ZXMvNzkKPiA+IEJ1aWxkLXRlc3RlZC1ieToga2VybmVsIHRlc3Qgcm9ib3QgPGxrcEBp bnRlbC5jb20+Cj4gPiBMaW5rOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzYwMzY0N2U0 LkRlRUZibDRlcWxqdXdBVWUlMjVsa3BAaW50ZWwuY29tLwo+ID4gU2lnbmVkLW9mZi1ieTogR3Vz dGF2byBBLiBSLiBTaWx2YSA8Z3VzdGF2b2Fyc0BrZXJuZWwub3JnPgo+ID4gLS0tCj4gPiAgIGZz L2YyZnMvZjJmcy5oICAgICAgICAgIHwgNSArKystLQo+ID4gICBpbmNsdWRlL2xpbnV4L2YyZnNf ZnMuaCB8IDIgKy0KPiA+ICAgMiBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9mcy9mMmZzL2YyZnMuaCBiL2ZzL2YyZnMv ZjJmcy5oCj4gPiBpbmRleCBlMmQzMDJhZTNhNDYuLjNmNWNiMDk3YzMwZiAxMDA2NDQKPiA+IC0t LSBhL2ZzL2YyZnMvZjJmcy5oCj4gPiArKysgYi9mcy9mMmZzL2YyZnMuaAo+ID4gQEAgLTIyMTUs NiArMjIxNSw3IEBAIHN0YXRpYyBpbmxpbmUgYmxvY2tfdCBfX2NwX3BheWxvYWQoc3RydWN0IGYy ZnNfc2JfaW5mbyAqc2JpKQo+ID4gICBzdGF0aWMgaW5saW5lIHZvaWQgKl9fYml0bWFwX3B0cihz dHJ1Y3QgZjJmc19zYl9pbmZvICpzYmksIGludCBmbGFnKQo+ID4gICB7Cj4gPiAgIAlzdHJ1Y3Qg ZjJmc19jaGVja3BvaW50ICpja3B0ID0gRjJGU19DS1BUKHNiaSk7Cj4gPiArCXZvaWQgKnRtcF9w dHIgPSAmY2twdC0+c2l0X25hdF92ZXJzaW9uX2JpdG1hcDsKPiA+ICAgCWludCBvZmZzZXQ7Cj4g PiAgIAlpZiAoaXNfc2V0X2NrcHRfZmxhZ3Moc2JpLCBDUF9MQVJHRV9OQVRfQklUTUFQX0ZMQUcp KSB7Cj4gPiBAQCAtMjIyNCw3ICsyMjI1LDcgQEAgc3RhdGljIGlubGluZSB2b2lkICpfX2JpdG1h cF9wdHIoc3RydWN0IGYyZnNfc2JfaW5mbyAqc2JpLCBpbnQgZmxhZykKPiA+ICAgCQkgKiBpZiBs YXJnZV9uYXRfYml0bWFwIGZlYXR1cmUgaXMgZW5hYmxlZCwgbGVhdmUgY2hlY2tzdW0KPiA+ICAg CQkgKiBwcm90ZWN0aW9uIGZvciBhbGwgbmF0L3NpdCBiaXRtYXBzLgo+ID4gICAJCSAqLwo+ID4g LQkJcmV0dXJuICZja3B0LT5zaXRfbmF0X3ZlcnNpb25fYml0bWFwICsgb2Zmc2V0ICsgc2l6ZW9m KF9fbGUzMik7Cj4gPiArCQlyZXR1cm4gdG1wX3B0ciArIG9mZnNldCArIHNpemVvZihfX2xlMzIp Owo+ID4gICAJfQo+ID4gICAJaWYgKF9fY3BfcGF5bG9hZChzYmkpID4gMCkgewo+ID4gQEAgLTIy MzUsNyArMjIzNiw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCAqX19iaXRtYXBfcHRyKHN0cnVjdCBm MmZzX3NiX2luZm8gKnNiaSwgaW50IGZsYWcpCj4gPiAgIAl9IGVsc2Ugewo+ID4gICAJCW9mZnNl dCA9IChmbGFnID09IE5BVF9CSVRNQVApID8KPiA+ICAgCQkJbGUzMl90b19jcHUoY2twdC0+c2l0 X3Zlcl9iaXRtYXBfYnl0ZXNpemUpIDogMDsKPiA+IC0JCXJldHVybiAmY2twdC0+c2l0X25hdF92 ZXJzaW9uX2JpdG1hcCArIG9mZnNldDsKPiA+ICsJCXJldHVybiB0bXBfcHRyICsgb2Zmc2V0Owo+ ID4gICAJfQo+ID4gICB9Cj4gPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9mMmZzX2ZzLmgg Yi9pbmNsdWRlL2xpbnV4L2YyZnNfZnMuaAo+ID4gaW5kZXggYzZjYzBhNTY2ZWY1Li41NDg3YTgw NjE3YTMgMTAwNjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L2YyZnNfZnMuaAo+ID4gKysrIGIv aW5jbHVkZS9saW51eC9mMmZzX2ZzLmgKPiA+IEBAIC0xNjgsNyArMTY4LDcgQEAgc3RydWN0IGYy ZnNfY2hlY2twb2ludCB7Cj4gPiAgIAl1bnNpZ25lZCBjaGFyIGFsbG9jX3R5cGVbTUFYX0FDVElW RV9MT0dTXTsKPiA+ICAgCS8qIFNJVCBhbmQgTkFUIHZlcnNpb24gYml0bWFwICovCj4gPiAtCXVu c2lnbmVkIGNoYXIgc2l0X25hdF92ZXJzaW9uX2JpdG1hcFsxXTsKPiA+ICsJdW5zaWduZWQgY2hh ciBzaXRfbmF0X3ZlcnNpb25fYml0bWFwW107Cj4gPiAgIH0gX19wYWNrZWQ7Cj4gPiAgICNkZWZp bmUgQ1BfQ0hLU1VNX09GRlNFVAk0MDkyCS8qIGRlZmF1bHQgY2hrc3VtIG9mZnNldCBpbiBjaGVj a3BvaW50ICovCj4gPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpMaW51eC1mMmZzLWRldmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxp c3RzLnNvdXJjZWZvcmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9s aXN0aW5mby9saW51eC1mMmZzLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B14C433E0 for ; Sun, 28 Feb 2021 05:01:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58A4464DEF for ; Sun, 28 Feb 2021 05:01:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229477AbhB1FBf (ORCPT ); Sun, 28 Feb 2021 00:01:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:55940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbhB1FBe (ORCPT ); Sun, 28 Feb 2021 00:01:34 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 37AE664DD3; Sun, 28 Feb 2021 05:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614488453; bh=xQkMVcApfL3t8q7iWpH6mY+eJIkLuQ6BUnZPCj+gU5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BNyRoc/oZOtX9taoGATLjm2dxB0dYBTzztSuW5ONJGVMhWcto8jYx1xD2rtIzLmUd N2j5SVb40RAK7hqsrCSUkV0bJDe8w7Vd65nFTzpn3hBeW/py7LEw+bgoTGIa7TUzDP P511iZxGBzZZRn79KYKl/HzQ4KXlivbUr4nIDBwq6dkGkkaM1pDdaFUAW2ueh72ZsQ UknI/6Hbum4BrrSSKa4jmgC79g8cSvDGE7VBg1n7DJMLx72CtBs+Ncc5aOlLFxdQFS yFKlFCtlvUgmJwogKAUJQKAxhnKZtoA2u3PCrTYh3dzEU7TVRyXM2Xq6mcS9obXkP/ ZUSfeO5eeH9/A== Date: Sat, 27 Feb 2021 21:00:51 -0800 From: Jaegeuk Kim To: Chao Yu Cc: "Gustavo A. R. Silva" , Chao Yu , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH][next] f2fs: Replace one-element array with flexible-array member Message-ID: References: <20210224190313.GA144040@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On 02/25, Chao Yu wrote: > Hello, Gustavo, > > On 2021/2/25 3:03, Gustavo A. R. Silva wrote: > > There is a regular need in the kernel to provide a way to declare having > > a dynamically sized set of trailing elements in a structure. Kernel code > > should always use “flexible array members”[1] for these cases. The older > > style of one-element or zero-length arrays should no longer be used[2]. > > I proposal to do the similar cleanup, and I've no objection on doing this. > > https://lore.kernel.org/patchwork/patch/869440/ > > Let's ask for Jaegeuk' opinion. Merged, thanks. This looks better reason than code readability. :) > > > > > Refactor the code according to the use of a flexible-array member in > > struct f2fs_checkpoint, instead of a one-element arrays. > > > > Notice that a temporary pointer to void '*tmp_ptr' was used in order to > > fix the following errors when using a flexible array instead of a one > > element array in struct f2fs_checkpoint: > > > > CC [M] fs/f2fs/dir.o > > In file included from fs/f2fs/dir.c:13: > > fs/f2fs/f2fs.h: In function ‘__bitmap_ptr’: > > fs/f2fs/f2fs.h:2227:40: error: invalid use of flexible array member > > 2227 | return &ckpt->sit_nat_version_bitmap + offset + sizeof(__le32); > > | ^ > > fs/f2fs/f2fs.h:2227:49: error: invalid use of flexible array member > > 2227 | return &ckpt->sit_nat_version_bitmap + offset + sizeof(__le32); > > | ^ > > fs/f2fs/f2fs.h:2238:40: error: invalid use of flexible array member > > 2238 | return &ckpt->sit_nat_version_bitmap + offset; > > | ^ > > make[2]: *** [scripts/Makefile.build:287: fs/f2fs/dir.o] Error 1 > > make[1]: *** [scripts/Makefile.build:530: fs/f2fs] Error 2 > > make: *** [Makefile:1819: fs] Error 2 > > > > [1] https://en.wikipedia.org/wiki/Flexible_array_member > > [2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays > > > > Link: https://github.com/KSPP/linux/issues/79 > > Build-tested-by: kernel test robot > > Link: https://lore.kernel.org/lkml/603647e4.DeEFbl4eqljuwAUe%25lkp@intel.com/ > > Signed-off-by: Gustavo A. R. Silva > > --- > > fs/f2fs/f2fs.h | 5 +++-- > > include/linux/f2fs_fs.h | 2 +- > > 2 files changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > > index e2d302ae3a46..3f5cb097c30f 100644 > > --- a/fs/f2fs/f2fs.h > > +++ b/fs/f2fs/f2fs.h > > @@ -2215,6 +2215,7 @@ static inline block_t __cp_payload(struct f2fs_sb_info *sbi) > > static inline void *__bitmap_ptr(struct f2fs_sb_info *sbi, int flag) > > { > > struct f2fs_checkpoint *ckpt = F2FS_CKPT(sbi); > > + void *tmp_ptr = &ckpt->sit_nat_version_bitmap; > > int offset; > > if (is_set_ckpt_flags(sbi, CP_LARGE_NAT_BITMAP_FLAG)) { > > @@ -2224,7 +2225,7 @@ static inline void *__bitmap_ptr(struct f2fs_sb_info *sbi, int flag) > > * if large_nat_bitmap feature is enabled, leave checksum > > * protection for all nat/sit bitmaps. > > */ > > - return &ckpt->sit_nat_version_bitmap + offset + sizeof(__le32); > > + return tmp_ptr + offset + sizeof(__le32); > > } > > if (__cp_payload(sbi) > 0) { > > @@ -2235,7 +2236,7 @@ static inline void *__bitmap_ptr(struct f2fs_sb_info *sbi, int flag) > > } else { > > offset = (flag == NAT_BITMAP) ? > > le32_to_cpu(ckpt->sit_ver_bitmap_bytesize) : 0; > > - return &ckpt->sit_nat_version_bitmap + offset; > > + return tmp_ptr + offset; > > } > > } > > diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h > > index c6cc0a566ef5..5487a80617a3 100644 > > --- a/include/linux/f2fs_fs.h > > +++ b/include/linux/f2fs_fs.h > > @@ -168,7 +168,7 @@ struct f2fs_checkpoint { > > unsigned char alloc_type[MAX_ACTIVE_LOGS]; > > /* SIT and NAT version bitmap */ > > - unsigned char sit_nat_version_bitmap[1]; > > + unsigned char sit_nat_version_bitmap[]; > > } __packed; > > #define CP_CHKSUM_OFFSET 4092 /* default chksum offset in checkpoint */ > >