From: Jarkko Sakkinen <jarkko@kernel.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm/ppi: Constify static struct attribute_group
Date: Mon, 1 Mar 2021 11:44:28 +0200 [thread overview]
Message-ID: <YDy3fC3gP1ydzbY0@kernel.org> (raw)
In-Reply-To: <YDlufJLcYN2bzNYV@rikard>
On Fri, Feb 26, 2021 at 10:56:12PM +0100, Rikard Falkeborn wrote:
> On Fri, Feb 05, 2021 at 04:04:18AM +0200, Jarkko Sakkinen wrote:
> > On Thu, Feb 04, 2021 at 10:54:27PM +0100, Rikard Falkeborn wrote:
> > > The only usage of ppi_attr_grp is to put its address in an array of
> > > pointers to const struct attribute_group. Make it const to allow the
> > > compiler to put it in read-only memory.
> > >
> > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> >
> > Thanks.
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> >
> > /Jarkko
> >
>
> Hi Jarkko,
> I saw this was merged as commit
> 90cba8d20f8b09d62a25f9864cb8e67722d76c3a, but in the commit, there was an
> additional change where a call to dump_stack() was added in
> drivers/char/tpm/tpm-chip.c, was this intentional?
No, thanks for reporting. I sent a fixup. Can you ack it?
/Jarkko
prev parent reply other threads:[~2021-03-01 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 21:54 [PATCH] tpm/ppi: Constify static struct attribute_group Rikard Falkeborn
2021-02-05 2:04 ` Jarkko Sakkinen
2021-02-26 21:56 ` Rikard Falkeborn
2021-03-01 9:44 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDy3fC3gP1ydzbY0@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.