From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [Automated-testing] [PATCH v2 2/5] lib: Add minimalistic json parser
Date: Mon, 1 Mar 2021 08:38:57 +0100 [thread overview]
Message-ID: <YDyaEd7xNx3NcMGE@pevik> (raw)
In-Reply-To: <20210224165045.17738-3-chrubis@suse.cz>
Hi Cyril,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Nice work!
> +static int eatws(struct tst_json_buf *buf)
> +{
> + while (!buf_empty(buf)) {
> + switch (buf->json[buf->off]) {
> + case ' ':
> + case '\t':
> + case '\n':
> + case '\f':
Shouldn't there be '\r' as well? (handled at copy_str()).
> + break;
> + default:
> + goto ret;
> + }
> +
> + buf->off += 1;
> + }
> +ret:
> + return buf_empty(buf);
> +}
Kind regards,
Petr
next prev parent reply other threads:[~2021-03-01 7:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 16:50 [LTP] [PATCH v2 0/5] Another attempt at hardware discovery Cyril Hrubis
2021-02-24 16:50 ` [LTP] [PATCH v2 1/5] lib: tst_cmd: Make tst_cmd() usable for global paths Cyril Hrubis
2021-02-24 17:57 ` [LTP] [Automated-testing] " Petr Vorel
2021-02-24 16:50 ` [LTP] [PATCH v2 2/5] lib: Add minimalistic json parser Cyril Hrubis
2021-03-01 7:38 ` Petr Vorel [this message]
2021-11-05 10:56 ` [LTP] [Automated-testing] " Richard Palethorpe
2021-11-05 11:16 ` Cyril Hrubis
2021-02-24 16:50 ` [LTP] [PATCH v2 3/5] lib: Add hardware discovery code Cyril Hrubis
2021-02-24 16:50 ` [LTP] [PATCH v2 4/5] Sample hardware discovery and reconfigure scripts Cyril Hrubis
2021-02-24 16:50 ` [LTP] [PATCH v2 5/5] testcases: uart01: Add Cyril Hrubis
2021-02-26 19:20 ` [LTP] [Automated-testing] [PATCH v2 0/5] Another attempt at hardware discovery Tim.Bird
2021-03-01 11:57 ` Cyril Hrubis
2021-11-05 10:30 ` Richard Palethorpe
2021-03-01 10:30 ` [LTP] " Cixi Geng
2021-03-01 13:24 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDyaEd7xNx3NcMGE@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.