From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: qcom: sc8180x: add ACPI probe support
Date: Mon, 1 Mar 2021 16:37:50 +0200 [thread overview]
Message-ID: <YDz8PtFy8PpdUlSF@smile.fi.intel.com> (raw)
In-Reply-To: <20210301014329.30104-3-shawn.guo@linaro.org>
On Mon, Mar 01, 2021 at 09:43:29AM +0800, Shawn Guo wrote:
> It adds ACPI probe support with tile offsets passed over to msm core
> driver via sc8180x_tile_offsets, as TLMM is described a single memory
> region in ACPI DSDT.
...
> config PINCTRL_SC8180X
> tristate "Qualcomm Technologies Inc SC8180x pin controller driver"
> - depends on GPIOLIB && OF
> + depends on GPIOLIB && (OF || ACPI)
Can you consider dropping OF dependency completely?
> +#include <linux/acpi.h>
No use of this header, see below.
(Perhaps you meant mod_devicetable.h)
...
> +static const u32 sc8180x_tile_offsets[] = {
> + 0x00d00000,
> + 0x00500000,
> + 0x00100000
Leave comma here.
> +};
...
> +static const int sc8180x_acpi_reserved_gpios[] = {
> + 0, 1, 2, 3,
> + 47, 48, 49, 50,
> + 126, 127, 128, 129,
> + -1
-1?
Is it kinda terminator?
> +};
...
> + if (pdev->dev.of_node) {
> + ret = msm_pinctrl_probe(pdev, &sc8180x_pinctrl);
> + } else if (has_acpi_companion(&pdev->dev)) {
> + ret = msm_pinctrl_probe(pdev, &sc8180x_acpi_pinctrl);
> + } else {
> + dev_err(&pdev->dev, "DT and ACPI disabled\n");
> + ret = -EINVAL;
> + }
Use driver_data field for this and device_get_match_data() instead of above.
...
> +#ifdef CONFIG_ACPI
Drop this ugly ifdeffery.
> +static const struct acpi_device_id sc8180x_pinctrl_acpi_match[] = {
> + { "QCOM040D"},
> + { },
No comma for terminator line.
> +};
> +MODULE_DEVICE_TABLE(acpi, sc8180x_pinctrl_acpi_match);
> +#endif
...
> + .acpi_match_table = ACPI_PTR(sc8180x_pinctrl_acpi_match),
No ACPI_PTR(), please.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-01 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 1:43 [PATCH 0/2] Add ACPI support for SC8180X pinctrl driver Shawn Guo
2021-03-01 1:43 ` [PATCH 1/2] pinctrl: qcom: handle tiles for ACPI boot Shawn Guo
2021-03-01 14:34 ` Andy Shevchenko
2021-03-02 1:57 ` Shawn Guo
2021-03-01 1:43 ` [PATCH 2/2] pinctrl: qcom: sc8180x: add ACPI probe support Shawn Guo
2021-03-01 14:37 ` Andy Shevchenko [this message]
2021-03-02 3:00 ` Shawn Guo
2021-03-01 14:32 ` [PATCH 0/2] Add ACPI support for SC8180X pinctrl driver Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDz8PtFy8PpdUlSF@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.