From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Xiaofei Tan <tanxiaofei@huawei.com>,
Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH] rtc: cmos: Disable irq around direct invocation of cmos_interrupt()
Date: Mon, 15 Mar 2021 22:49:08 +0100 [thread overview]
Message-ID: <YE/WVGaqJafUFbaC@piout.net> (raw)
In-Reply-To: <YEIx2MetiHDXdrcL@intel.com>
On 05/03/2021 15:27:52+0200, Ville Syrjälä wrote:
> > which breaks S3-resume on fi-kbl-soraka presumably as that's slow enough
> > to trigger the alarm during the suspend.
> >
> > Fixes: 6950d046eb6e ("rtc: cmos: Replace spin_lock_irqsave with spin_lock in hard IRQ")
>
> Sigh. I wish people would at least try to check the code/history
> before doing these blind "cleanups" :(
>
Sorry I didn't catch that when applying. I'm usually more wary when
getting those kind of cleanups.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-03-15 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 12:21 [PATCH] rtc: cmos: Disable irq around direct invocation of cmos_interrupt() Chris Wilson
2021-03-05 13:27 ` Ville Syrjälä
2021-03-15 21:49 ` Alexandre Belloni [this message]
2021-03-15 21:42 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YE/WVGaqJafUFbaC@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=chris@chris-wilson.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=tanxiaofei@huawei.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.