From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAFFCC433E0 for ; Mon, 15 Mar 2021 16:56:29 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 5853964F33 for ; Mon, 15 Mar 2021 16:56:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5853964F33 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CFF494B3CE; Mon, 15 Mar 2021 12:56:28 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zHuJ5eBAKSlE; Mon, 15 Mar 2021 12:56:27 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C6FA14B442; Mon, 15 Mar 2021 12:56:27 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D0BCF4B1BE for ; Mon, 15 Mar 2021 12:56:26 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DAzdfo8458vc for ; Mon, 15 Mar 2021 12:56:25 -0400 (EDT) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D80D34B340 for ; Mon, 15 Mar 2021 12:56:25 -0400 (EDT) Received: by mail-wm1-f52.google.com with SMTP id g25so8522898wmh.0 for ; Mon, 15 Mar 2021 09:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Y+xprG6vtxLrLveW5ZtmXkAhTW+9ve7ImVtbj1EZZHk=; b=mrnugUQmzKMeO4p3w/jnYU3L1WrHmqn69Ewz5QiylBU/GCQ7x2L5iCA/2VLhI22o1f W7jrrGpK5WWx3YVj7oM5uobQdYkmkHBrkxM8eBM/wtyNCQ4B3xtYrO0pRfS2MHwwMm/i r/yLef5VBQeLl5z7LufUnSYeT6PSQvb4YAx4eHzXliCNP0KVZVVrmT2OE9ql2ZoUCj4h 6qLCrwsSJSS8Y7DinACPvae2jg3sDwxPbWHNSNB+c75KtEIH5lOiOTB+Tpk/HrTM4ABe gEjS0u885Zc+dHqAvZDyTfOraMGPj1KodeE4dzb6MOdSO+ppf8lS43Ce2F1tOKysy4CZ VMKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y+xprG6vtxLrLveW5ZtmXkAhTW+9ve7ImVtbj1EZZHk=; b=dBqOGoP5nbMi0STJ5H1FudS3JM5eJnvNVfW3uYn5W451J0GYY5kt5n4Kx87kR2TTpK gKfOObktNAHIFW+d4z00kh9cWQsM7uWFozg1gUhkxB7c7VwbTd5n69RApQ9IyZK3q4pr AnyW39P5YTiUsPUzqaliNnmlS6nKpQrmz2LClgKnfKYVNMuGEV39zHr15LKAGsg/i8IE pRWgeBf2hH5wHBs/McYuRap3JPJEYqi1Ly9MP7eRBIpzMR8lLsH2DyVKjKSYWLjIYqT2 80K1Tvxsu3xGTE0lh9PcbCJdjjnUYxnMldHdLudW7JsjZo5wfildewvAMHsPrbN75xEh I+7g== X-Gm-Message-State: AOAM533XdVOVqz9Y0TL70H/FPJGeetsxj0nYMXW0BAnzsigDbnodxN8e zWiKIm9pH8fyTleUTplbh9S50w== X-Google-Smtp-Source: ABdhPJxvHGew9n7ZzD/LWAiEsnPZPO/Aweogz7praM5dvQpdXhh8dOt7XfTLD17acpcb9/3p3JioXA== X-Received: by 2002:a1c:c206:: with SMTP id s6mr563841wmf.77.1615827384635; Mon, 15 Mar 2021 09:56:24 -0700 (PDT) Received: from google.com (230.69.233.35.bc.googleusercontent.com. [35.233.69.230]) by smtp.gmail.com with ESMTPSA id s18sm22046028wrr.27.2021.03.15.09.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 09:56:24 -0700 (PDT) Date: Mon, 15 Mar 2021 16:56:21 +0000 From: Quentin Perret To: Will Deacon Subject: Re: [PATCH v5 14/36] KVM: arm64: Provide __flush_dcache_area at EL2 Message-ID: References: <20210315143536.214621-1-qperret@google.com> <20210315143536.214621-15-qperret@google.com> <20210315163322.GE3430@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210315163322.GE3430@willie-the-truck> Cc: android-kvm@google.com, catalin.marinas@arm.com, mate.toth-pal@arm.com, seanjc@google.com, tabba@google.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Monday 15 Mar 2021 at 16:33:23 (+0000), Will Deacon wrote: > On Mon, Mar 15, 2021 at 02:35:14PM +0000, Quentin Perret wrote: > > We will need to do cache maintenance at EL2 soon, so compile a copy of > > __flush_dcache_area at EL2, and provide a copy of arm64_ftr_reg_ctrel0 > > as it is needed by the read_ctr macro. > > > > Signed-off-by: Quentin Perret > > --- > > arch/arm64/include/asm/kvm_cpufeature.h | 2 ++ > > arch/arm64/kvm/hyp/nvhe/Makefile | 3 ++- > > arch/arm64/kvm/hyp/nvhe/cache.S | 13 +++++++++++++ > > arch/arm64/kvm/sys_regs.c | 1 + > > 4 files changed, 18 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm64/kvm/hyp/nvhe/cache.S > > > > diff --git a/arch/arm64/include/asm/kvm_cpufeature.h b/arch/arm64/include/asm/kvm_cpufeature.h > > index 3fd9f60d2180..efba1b89b8a4 100644 > > --- a/arch/arm64/include/asm/kvm_cpufeature.h > > +++ b/arch/arm64/include/asm/kvm_cpufeature.h > > @@ -13,3 +13,5 @@ > > #define KVM_HYP_CPU_FTR_REG(name) extern struct arm64_ftr_reg kvm_nvhe_sym(name) > > #endif > > #endif > > + > > +KVM_HYP_CPU_FTR_REG(arm64_ftr_reg_ctrel0); > > I still think this is a bit weird. If you really want to macro-ise stuff, > then why not follow the sort of thing we do for e.g. per-cpu variables and > have separate DECLARE_HYP_CPU_FTR_REG and DEFINE_HYP_CPU_FTR_REG macros. > > That way kvm_cpufeature.h can have header guards like a normal header and > we can drop the '#ifndef KVM_HYP_CPU_FTR_REG' altogether. I don't think > the duplication of the symbol name really matters -- it should fail at > build time if something is missing. I just tend to hate unnecessary boilerplate, but if you feel strongly about it, happy to change :) Cheers, Quentin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67EBDC433E0 for ; Mon, 15 Mar 2021 16:58:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E35D464F33 for ; Mon, 15 Mar 2021 16:58:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E35D464F33 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+WWx7O8OWl+OIt4DV+piFkdcXHc+GsjBrr9Jc2R3fIw=; b=mNVXMuQ03VS3SLeN9O9gmj25+ D7uYefTYybp4pRP7Qx9qkAH0lsu4S/O6SzTAs3xW5VrFQZrLidwatpckWxlCvsPy1zGBvRykCJdL5 iRs6EhK6NEqcOWac46Ztkgp/byPH5C6aA7nsrYmiirZrnvRT1gq/PYzuT7NNtQ+Pau5OGVwaclEyn R/hWZPqvzI7X6QwLH9Fvw3K5TPsRFjez7ONgJIJ0ZJuyyxWkVNpFJPqt0vto8nlSch+I/L/eTydtO iu4e01WoAj5InAbhHFr+KvwVd/h5T0ynUSfVQYfbFDUrA8Ul3DUa7S3vrH4AB29edEj45KdX6Sdtr khAR1ebeg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLqW5-00GPPk-GS; Mon, 15 Mar 2021 16:56:30 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLqW1-00GPPG-E5 for linux-arm-kernel@lists.infradead.org; Mon, 15 Mar 2021 16:56:27 +0000 Received: by mail-wm1-x32f.google.com with SMTP id l19so8535478wmh.1 for ; Mon, 15 Mar 2021 09:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Y+xprG6vtxLrLveW5ZtmXkAhTW+9ve7ImVtbj1EZZHk=; b=mrnugUQmzKMeO4p3w/jnYU3L1WrHmqn69Ewz5QiylBU/GCQ7x2L5iCA/2VLhI22o1f W7jrrGpK5WWx3YVj7oM5uobQdYkmkHBrkxM8eBM/wtyNCQ4B3xtYrO0pRfS2MHwwMm/i r/yLef5VBQeLl5z7LufUnSYeT6PSQvb4YAx4eHzXliCNP0KVZVVrmT2OE9ql2ZoUCj4h 6qLCrwsSJSS8Y7DinACPvae2jg3sDwxPbWHNSNB+c75KtEIH5lOiOTB+Tpk/HrTM4ABe gEjS0u885Zc+dHqAvZDyTfOraMGPj1KodeE4dzb6MOdSO+ppf8lS43Ce2F1tOKysy4CZ VMKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y+xprG6vtxLrLveW5ZtmXkAhTW+9ve7ImVtbj1EZZHk=; b=NPW/qgnBfI4885egeJ1p7WA8FdFbHuO39Tuen26qfaCfcaM5otnwjAqW6gLKkuR5AD 6MzjSRQUUv85cnnNwBqU3AposmK1NhQM7oIS3WVjaXrJ7FJgo/Fv5mmBAql5jRwC052l nQ+Jxm1FIcjGOJf6hSzeHdyzGHZFfAlL1WyPkCgoVwxMCSZAG1K0/AQEk1h6vl5T4GHY MYoQANx+ygYcx16bZX/TKQq2/Qu7nXinhUidGziqNiIqlxgflJdW0Elb4+Cm9IwzNKCj z6tHR+hqyw1HtPzXNsYiHURXbkHngeNANBjoIHqPN/qVxbmCcLbf/bjvpjT2ZdP9Tyam ZW1A== X-Gm-Message-State: AOAM5330ml2VE1X2z4bYVo8XsbW0AAJLY0Ple1MZfrElLZvDUCw3fg/I WiJysILogVvOAi1+M7oj9uJeFw== X-Google-Smtp-Source: ABdhPJxvHGew9n7ZzD/LWAiEsnPZPO/Aweogz7praM5dvQpdXhh8dOt7XfTLD17acpcb9/3p3JioXA== X-Received: by 2002:a1c:c206:: with SMTP id s6mr563841wmf.77.1615827384635; Mon, 15 Mar 2021 09:56:24 -0700 (PDT) Received: from google.com (230.69.233.35.bc.googleusercontent.com. [35.233.69.230]) by smtp.gmail.com with ESMTPSA id s18sm22046028wrr.27.2021.03.15.09.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 09:56:24 -0700 (PDT) Date: Mon, 15 Mar 2021 16:56:21 +0000 From: Quentin Perret To: Will Deacon Cc: catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, android-kvm@google.com, seanjc@google.com, mate.toth-pal@arm.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, tabba@google.com, ardb@kernel.org, mark.rutland@arm.com, dbrazdil@google.com Subject: Re: [PATCH v5 14/36] KVM: arm64: Provide __flush_dcache_area at EL2 Message-ID: References: <20210315143536.214621-1-qperret@google.com> <20210315143536.214621-15-qperret@google.com> <20210315163322.GE3430@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210315163322.GE3430@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_165625_959485_EF0D6BAF X-CRM114-Status: GOOD ( 25.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday 15 Mar 2021 at 16:33:23 (+0000), Will Deacon wrote: > On Mon, Mar 15, 2021 at 02:35:14PM +0000, Quentin Perret wrote: > > We will need to do cache maintenance at EL2 soon, so compile a copy of > > __flush_dcache_area at EL2, and provide a copy of arm64_ftr_reg_ctrel0 > > as it is needed by the read_ctr macro. > > > > Signed-off-by: Quentin Perret > > --- > > arch/arm64/include/asm/kvm_cpufeature.h | 2 ++ > > arch/arm64/kvm/hyp/nvhe/Makefile | 3 ++- > > arch/arm64/kvm/hyp/nvhe/cache.S | 13 +++++++++++++ > > arch/arm64/kvm/sys_regs.c | 1 + > > 4 files changed, 18 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm64/kvm/hyp/nvhe/cache.S > > > > diff --git a/arch/arm64/include/asm/kvm_cpufeature.h b/arch/arm64/include/asm/kvm_cpufeature.h > > index 3fd9f60d2180..efba1b89b8a4 100644 > > --- a/arch/arm64/include/asm/kvm_cpufeature.h > > +++ b/arch/arm64/include/asm/kvm_cpufeature.h > > @@ -13,3 +13,5 @@ > > #define KVM_HYP_CPU_FTR_REG(name) extern struct arm64_ftr_reg kvm_nvhe_sym(name) > > #endif > > #endif > > + > > +KVM_HYP_CPU_FTR_REG(arm64_ftr_reg_ctrel0); > > I still think this is a bit weird. If you really want to macro-ise stuff, > then why not follow the sort of thing we do for e.g. per-cpu variables and > have separate DECLARE_HYP_CPU_FTR_REG and DEFINE_HYP_CPU_FTR_REG macros. > > That way kvm_cpufeature.h can have header guards like a normal header and > we can drop the '#ifndef KVM_HYP_CPU_FTR_REG' altogether. I don't think > the duplication of the symbol name really matters -- it should fail at > build time if something is missing. I just tend to hate unnecessary boilerplate, but if you feel strongly about it, happy to change :) Cheers, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C670DC433E9 for ; Mon, 15 Mar 2021 16:57:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A490B64F3A for ; Mon, 15 Mar 2021 16:57:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233873AbhCOQ4g (ORCPT ); Mon, 15 Mar 2021 12:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233906AbhCOQ41 (ORCPT ); Mon, 15 Mar 2021 12:56:27 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E96CC061764 for ; Mon, 15 Mar 2021 09:56:26 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id g20so8541079wmk.3 for ; Mon, 15 Mar 2021 09:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Y+xprG6vtxLrLveW5ZtmXkAhTW+9ve7ImVtbj1EZZHk=; b=mrnugUQmzKMeO4p3w/jnYU3L1WrHmqn69Ewz5QiylBU/GCQ7x2L5iCA/2VLhI22o1f W7jrrGpK5WWx3YVj7oM5uobQdYkmkHBrkxM8eBM/wtyNCQ4B3xtYrO0pRfS2MHwwMm/i r/yLef5VBQeLl5z7LufUnSYeT6PSQvb4YAx4eHzXliCNP0KVZVVrmT2OE9ql2ZoUCj4h 6qLCrwsSJSS8Y7DinACPvae2jg3sDwxPbWHNSNB+c75KtEIH5lOiOTB+Tpk/HrTM4ABe gEjS0u885Zc+dHqAvZDyTfOraMGPj1KodeE4dzb6MOdSO+ppf8lS43Ce2F1tOKysy4CZ VMKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y+xprG6vtxLrLveW5ZtmXkAhTW+9ve7ImVtbj1EZZHk=; b=I5cklJLXKibJyHXWl21SHgHGNZbwsC6FELlfyeyymB8aWKAZCrUUfTN6iazCmstudG 1ntGKQLt+D/Zi67a2cGZU/gYiNmn8S1xXgEGe5U7D3IYM3raPJ1+B4hjPZ0Xpx4n7EsL vrVSdhUpZeWl2ponxJZSUwFQh58pekOphEQi8xLVzr/95O0VRibtjUQ0STZPfqS1LVCh OEW9lK4O2pyKhrfT5mc9GSxHJ+8PKnB7V42TrCBbZOKGKxDWC0biUwv3x0lEpYODwcl5 VO8ageKZadJImasjR5Gpk9h/JjypNuiPVhFZSqduzRGEfLmjEhkZTZjV9JWECO7XuuRA 8YuA== X-Gm-Message-State: AOAM530fHeyapMCfHTpVMC4g6H5J+pcLJp8QMFMtpuTRUdy6WxiVNjIk f9kjRbHOYKUg/xomp75/1xINng== X-Google-Smtp-Source: ABdhPJxvHGew9n7ZzD/LWAiEsnPZPO/Aweogz7praM5dvQpdXhh8dOt7XfTLD17acpcb9/3p3JioXA== X-Received: by 2002:a1c:c206:: with SMTP id s6mr563841wmf.77.1615827384635; Mon, 15 Mar 2021 09:56:24 -0700 (PDT) Received: from google.com (230.69.233.35.bc.googleusercontent.com. [35.233.69.230]) by smtp.gmail.com with ESMTPSA id s18sm22046028wrr.27.2021.03.15.09.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 09:56:24 -0700 (PDT) Date: Mon, 15 Mar 2021 16:56:21 +0000 From: Quentin Perret To: Will Deacon Cc: catalin.marinas@arm.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, android-kvm@google.com, seanjc@google.com, mate.toth-pal@arm.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, tabba@google.com, ardb@kernel.org, mark.rutland@arm.com, dbrazdil@google.com Subject: Re: [PATCH v5 14/36] KVM: arm64: Provide __flush_dcache_area at EL2 Message-ID: References: <20210315143536.214621-1-qperret@google.com> <20210315143536.214621-15-qperret@google.com> <20210315163322.GE3430@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315163322.GE3430@willie-the-truck> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 15 Mar 2021 at 16:33:23 (+0000), Will Deacon wrote: > On Mon, Mar 15, 2021 at 02:35:14PM +0000, Quentin Perret wrote: > > We will need to do cache maintenance at EL2 soon, so compile a copy of > > __flush_dcache_area at EL2, and provide a copy of arm64_ftr_reg_ctrel0 > > as it is needed by the read_ctr macro. > > > > Signed-off-by: Quentin Perret > > --- > > arch/arm64/include/asm/kvm_cpufeature.h | 2 ++ > > arch/arm64/kvm/hyp/nvhe/Makefile | 3 ++- > > arch/arm64/kvm/hyp/nvhe/cache.S | 13 +++++++++++++ > > arch/arm64/kvm/sys_regs.c | 1 + > > 4 files changed, 18 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm64/kvm/hyp/nvhe/cache.S > > > > diff --git a/arch/arm64/include/asm/kvm_cpufeature.h b/arch/arm64/include/asm/kvm_cpufeature.h > > index 3fd9f60d2180..efba1b89b8a4 100644 > > --- a/arch/arm64/include/asm/kvm_cpufeature.h > > +++ b/arch/arm64/include/asm/kvm_cpufeature.h > > @@ -13,3 +13,5 @@ > > #define KVM_HYP_CPU_FTR_REG(name) extern struct arm64_ftr_reg kvm_nvhe_sym(name) > > #endif > > #endif > > + > > +KVM_HYP_CPU_FTR_REG(arm64_ftr_reg_ctrel0); > > I still think this is a bit weird. If you really want to macro-ise stuff, > then why not follow the sort of thing we do for e.g. per-cpu variables and > have separate DECLARE_HYP_CPU_FTR_REG and DEFINE_HYP_CPU_FTR_REG macros. > > That way kvm_cpufeature.h can have header guards like a normal header and > we can drop the '#ifndef KVM_HYP_CPU_FTR_REG' altogether. I don't think > the duplication of the symbol name really matters -- it should fail at > build time if something is missing. I just tend to hate unnecessary boilerplate, but if you feel strongly about it, happy to change :) Cheers, Quentin