From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20D3CC433E9 for ; Mon, 15 Mar 2021 18:50:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB9A264F4B for ; Mon, 15 Mar 2021 18:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232268AbhCOSuB (ORCPT ); Mon, 15 Mar 2021 14:50:01 -0400 Received: from mga09.intel.com ([134.134.136.24]:11157 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231956AbhCOSth (ORCPT ); Mon, 15 Mar 2021 14:49:37 -0400 IronPort-SDR: emUrZaC6HZp69aZ/YK4wCxOfrL0aCaQIxWDJlI6YP6OR3E4rerI54d3SX2O4bO4d/O7tSV7zue qFGQPwkWFBdA== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="189229645" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="189229645" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2021 11:49:29 -0700 IronPort-SDR: smpqX6XBZLNQYi/uw+E1RhoCqVRlIQTe4xxlC7aKIhngCJU2UJgP2yevO+ubIdKUp6wShF5cHb MloBDap+/Rtw== X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="511133334" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2021 11:49:26 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lLsHK-00Ckak-Pu; Mon, 15 Mar 2021 20:49:22 +0200 Date: Mon, 15 Mar 2021 20:49:22 +0200 From: Andy Shevchenko To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: Re: [PATCH v1 1/1] gpiolib: Assign fwnode to parent's if no primary one provided Message-ID: References: <20210315184430.17755-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315184430.17755-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Mar 15, 2021 at 08:44:30PM +0200, Andy Shevchenko wrote: > In case when the properties are supplied in the secondary fwnode > (for example, built-in device properties) the fwnode pointer left > unassigned. This makes unable to retrieve them. > > Assign fwnode to parent's if no primary one provided. Bart, I missed to add you as a Reporter, feel free to do that or tell me I'll send a v2. > Fixes: 7cba1a4d5e16 ("gpiolib: generalize devprop_gpiochip_set_names() for device properties") > Fixes: 2afa97e9868f ("gpiolib: Read "gpio-line-names" from a firmware node") > Signed-off-by: Andy Shevchenko Side note: The patch done in this way to avoid conflicts with the future (for-next) code once it will be in upstream (v5.12-rcX). -- With Best Regards, Andy Shevchenko