From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Marek Vasut <marex@denx.de>,
Roman Guskov <rguskov@dh-electronics.com>
Subject: Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node
Date: Mon, 15 Mar 2021 12:16:26 +0200 [thread overview]
Message-ID: <YE8z+ohM9abBs9SD@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=Mfye=O4mMiK01Q6Ok+ztSfMwMcrfaZSs+LhRxi=AM+C2w@mail.gmail.com>
On Mon, Mar 15, 2021 at 10:01:47AM +0100, Bartosz Golaszewski wrote:
> On Fri, Mar 5, 2021 at 1:03 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> Unfortunately while this may fix the particular use-case on STM32, it
> breaks all other users as the 'gpio-line-names' property doesn't live
> on dev_fwnode(&gdev->dev) but on dev_fwnode(chip->parent).
>
> How about we first look for this property on the latter and only if
> it's not present descend down to the former fwnode?
Oops, I have tested on x86 and it worked the same way.
Lemme check this, but I think the issue rather in ordering when we apply fwnode
to the newly created device and when we actually retrieve gpio-line-names
property.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-15 10:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 12:02 [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node Andy Shevchenko
2021-03-05 12:11 ` Marek Vasut
2021-03-05 12:24 ` Andy Shevchenko
2021-03-05 12:26 ` Marek Vasut
2021-03-07 13:55 ` Bartosz Golaszewski
2021-03-07 16:14 ` Andy Shevchenko
2021-03-08 11:45 ` Andy Shevchenko
2021-03-08 13:00 ` Bartosz Golaszewski
2021-03-15 9:01 ` Bartosz Golaszewski
2021-03-15 10:16 ` Andy Shevchenko [this message]
2021-03-15 12:50 ` Andy Shevchenko
2021-03-15 14:04 ` Bartosz Golaszewski
2021-03-15 14:34 ` Andy Shevchenko
2021-03-15 16:47 ` Bartosz Golaszewski
2021-03-15 17:04 ` Andy Shevchenko
2021-04-10 0:45 ` Marek Vasut
2021-04-10 9:06 ` Bartosz Golaszewski
2021-04-10 13:18 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YE8z+ohM9abBs9SD@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=rguskov@dh-electronics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.