From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH] qemu-option: do not suggest using the delay option
Date: Thu, 4 Mar 2021 10:54:47 +0000 [thread overview]
Message-ID: <YEC8dzjw30mokDXl@redhat.com> (raw)
In-Reply-To: <20210304102827.106522-1-pbonzini@redhat.com>
On Thu, Mar 04, 2021 at 11:28:27AM +0100, Paolo Bonzini wrote:
> The "delay" option was a hack that was introduced to allow writing "nodelay".
> We are adding a "nodelay" option to be used as "nodelay=on", so recommend it
> instead of "delay".
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> This is quite ugly, so I am posting it as RFC in case others
> have better idea. Nevertheless, a proper deprecation of "delay"
> cannot be done if QEMU starts suggesting it, and since it's the
> only case I opted for this very much ad-hoc patch.
It is ugly, but this is a rare enough edge case that I think we can live
with it.
> ---
> docs/system/deprecated.rst | 6 ++++++
> util/qemu-option.c | 7 ++++++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2021-03-04 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 10:28 [PATCH] qemu-option: do not suggest using the delay option Paolo Bonzini
2021-03-04 10:54 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEC8dzjw30mokDXl@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.