All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Felipe Balbi <balbi@kernel.org>, Ray Chi <raychi@google.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: Flip condition guarding power_supply_put()
Date: Thu, 4 Mar 2021 09:21:56 +0100	[thread overview]
Message-ID: <YECYpPY0ZxEr0A60@kroah.com> (raw)
In-Reply-To: <20210303192614.759729-1-bjorn.andersson@linaro.org>

On Wed, Mar 03, 2021 at 11:26:14AM -0800, Bjorn Andersson wrote:
> The condition guarding the power_supply_put() calls in error and
> removal paths are backwards, resulting in a guaranteed NULL pointer
> dereference if no power supply was acquired.
> 
> Fixes: 59fa3def35de ("usb: dwc3: add a power supply for current control")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  drivers/usb/dwc3/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Already fixed:
	d05a12f0478c ("usb: dwc3: Fix dereferencing of null dwc->usb_psy")

thanks,

greg k-h

      reply	other threads:[~2021-03-04  8:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 19:26 [PATCH] usb: dwc3: Flip condition guarding power_supply_put() Bjorn Andersson
2021-03-04  8:21 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YECYpPY0ZxEr0A60@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=raychi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.