Re: [PATCH v2] Autoconnect jack ports by default

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Mar 04, 2021 at 12:24:44PM +0100, Christian Schoenebeck wrote:
> On Mittwoch, 3. März 2021 08:13:06 CET Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > JACK clients with consumer purpose often auto connect to system ports by
> > > default because their users mostly use JACK just as a consumer desktop
> > > sound server. And I assume this applies to José as well.
> > 
> > Hmm, ok.  I'd suggest to simply change the default for connect-ports
> > then, that'll allow the user to easily change the behavior by setting
> > connect-ports to something else (including the empty string to disable
> > autoconnect).
> > 
> > take care,
> >   Gerd
> 
> Geoffrey, any chance to make you happy as well? E.g. either reserving "none" 
> as special value for "connect-ports" or an additional CL argument
> "no-connect-ports" to make it appear less hackish?

Adding special semantics for existing options generally ends up being
a bad idea in retrospect.

Inverse boolean options are also not very desirable.

I'd suggest a "auto-connect-ports" boolean option, which defaults to
enabled.


 - auto-connect-ports == true,  connect-ports= <unset>

    => use the proposed default regex for connect ports

 - auto-connect-ports == true, connect-ports = regex

    => use the connect-ports regex

 - auto-connect-ports == false, connect-ports= <unset>

   => don't auto connect at all

 - auto-connect-ports == false, connect-ports=regex

   => logically inconsistent config, report an error

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|