From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Li Wang <li.wang@windriver.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [V2][PATCH] vt: keyboard, fix uninitialized variables warning
Date: Thu, 4 Mar 2021 14:28:55 +0200 [thread overview]
Message-ID: <YEDSh/1OScaKWdxL@smile.fi.intel.com> (raw)
In-Reply-To: <1614827448-1594-1-git-send-email-li.wang@windriver.com>
On Thu, Mar 04, 2021 at 11:10:48AM +0800, Li Wang wrote:
> drivers/tty/vt/keyboard.c: In function 'vt_do_kdgkb_ioctl':
> drivers/tty/vt/keyboard.c: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
> return ret;
> ^~~
> drivers/tty/vt/keyboard.c: warning: 'kbs' may be used uninitialized in this function [-Wmaybe-uninitialized]
> kfree(kbs);
Let me add one more comment and summarize altogether:
- Jiri wants you to have different error code
- Greg (and I noticed that as well) wants you to add a proper commit message,
and not just some output of some tool w/o context
- I want you to send a new version w/o chaining to the previous thread, so
start new (email) thread every time you send a new version
Waiting for v3 in a separate email thread, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-04 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 4:59 [PATCH] vt: keyboard, fix uninitialized variables warning Li Wang
2021-03-03 7:14 ` Greg KH
2021-03-03 7:33 ` Wang, Li
2021-03-03 7:39 ` Greg KH
2021-03-03 8:24 ` Andy Shevchenko
2021-03-03 9:21 ` Wang, Li
2021-03-04 3:10 ` [V2][PATCH] " Li Wang
2021-03-04 7:03 ` Jiri Slaby
2021-03-04 7:04 ` Greg KH
2021-03-04 12:28 ` Andy Shevchenko [this message]
2021-03-04 12:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEDSh/1OScaKWdxL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=li.wang@windriver.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.