From: Greg KH <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Bartosz Golaszewski" <brgl@bgdev.pl>,
"Joel Becker" <jlbec@evilplan.org>,
"Christoph Hellwig" <hch@lst.de>, "Shuah Khan" <shuah@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Kent Gibson" <warthog618@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2 08/12] drivers: export device_is_bound()
Date: Fri, 5 Mar 2021 09:33:32 +0100 [thread overview]
Message-ID: <YEHs3CxWnusWklME@kroah.com> (raw)
In-Reply-To: <CAMuHMdXRK5=w1-Z=EbM60Sf2bLY1EiVaxbZjMP+XyQ3g7nBpZw@mail.gmail.com>
On Fri, Mar 05, 2021 at 09:18:30AM +0100, Geert Uytterhoeven wrote:
> CC Greg
>
> On Thu, Mar 4, 2021 at 11:30 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Export the symbol for device_is_bound() so that we can use it in gpio-sim
> > to check if the simulated GPIO chip is bound before fetching its driver
> > data from configfs callbacks in order to retrieve the name of the GPIO
> > chip device.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
> > drivers/base/dd.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> > index 9179825ff646..c62c02e3490a 100644
> > --- a/drivers/base/dd.c
> > +++ b/drivers/base/dd.c
> > @@ -353,6 +353,7 @@ bool device_is_bound(struct device *dev)
> > {
> > return dev->p && klist_node_attached(&dev->p->knode_driver);
> > }
> > +EXPORT_SYMBOL_GPL(device_is_bound);
No. Please no. Why is this needed? Feels like someone is doing
something really wrong...
NACK.
next prev parent reply other threads:[~2021-03-05 8:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 10:24 [PATCH v2 00/12] gpio: implement the configfs testing module Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 01/12] configfs: increase the item name length Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 02/12] configfs: use (1UL << bit) for internal flags Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 03/12] configfs: implement committable items Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 04/12] samples: configfs: add a committable group Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 05/12] lib: bitmap: remove the 'extern' keyword from function declarations Bartosz Golaszewski
2021-03-04 12:58 ` Andy Shevchenko
2021-03-09 14:44 ` Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 06/12] lib: bitmap: order includes alphabetically Bartosz Golaszewski
2021-03-04 12:59 ` Andy Shevchenko
2021-03-04 10:24 ` [PATCH v2 07/12] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc() Bartosz Golaszewski
2021-03-04 13:01 ` Andy Shevchenko
2021-03-04 10:24 ` [PATCH v2 08/12] drivers: export device_is_bound() Bartosz Golaszewski
2021-03-05 8:18 ` Geert Uytterhoeven
2021-03-05 8:33 ` Greg KH [this message]
2021-03-05 8:45 ` Bartosz Golaszewski
2021-03-05 8:55 ` Greg KH
2021-03-05 9:16 ` Bartosz Golaszewski
2021-03-05 10:24 ` Greg KH
2021-03-05 10:58 ` Bartosz Golaszewski
2021-03-05 11:27 ` Greg KH
2021-03-05 14:20 ` Bartosz Golaszewski
2021-03-05 15:01 ` Greg KH
2021-03-08 10:58 ` Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 09/12] gpio: sim: new testing module Bartosz Golaszewski
2021-03-04 13:15 ` Andy Shevchenko
2021-03-04 20:15 ` Bartosz Golaszewski
2021-03-05 10:15 ` Andy Shevchenko
2021-03-08 14:23 ` Bartosz Golaszewski
2021-03-08 15:04 ` Andy Shevchenko
2021-03-08 15:13 ` Bartosz Golaszewski
2021-03-08 15:32 ` Andy Shevchenko
2021-03-08 15:37 ` Bartosz Golaszewski
2021-03-08 16:37 ` Andy Shevchenko
2021-03-04 10:24 ` [PATCH v2 10/12] selftests: gpio: provide a helper for reading chip info Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 11/12] selftests: gpio: add a helper for reading GPIO line names Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 12/12] selftests: gpio: add test cases for gpio-sim Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEHs3CxWnusWklME@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.