All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	David Jander <david@protonic.nl>,
	Robin van der Gracht <robin@protonic.nl>,
	linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller
Date: Sun, 7 Mar 2021 15:05:31 -0800	[thread overview]
Message-ID: <YEVcO/NeKzBsFEdL@google.com> (raw)
In-Reply-To: <20210305133813.27967-3-o.rempel@pengutronix.de>

Hi Oleksij,

On Fri, Mar 05, 2021 at 02:38:13PM +0100, Oleksij Rempel wrote:
> +
> +	/* TODO: remove IRQ_NOAUTOEN after needed patches are mainline */
> +	irq_set_status_flags(spi->irq, IRQ_NOAUTOEN);
> +	ret = devm_request_threaded_irq(dev, spi->irq,
> +					NULL,
> +					&tsc2046_adc_irq,
> +					IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> +					name, indio_dev);

I'd recommend dropping IRQF_TRIGGER_LOW and only using IRQF_ONESHOT and
rely on the platform (ACPI, DT) to specify trigger polarity according to
how device is wired in a given system. In general I believe newer
drivers should not specify interrupt triggers themselves.

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2021-03-07 23:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 13:38 [PATCH v1 0/2] mainline ti tsc2046 adc driver Oleksij Rempel
2021-03-05 13:38 ` [PATCH v1 1/2] dt-bindings:iio:adc: add documentation for TI TSC2046 controller Oleksij Rempel
2021-03-08 22:18   ` Rob Herring
2021-03-05 13:38 ` [PATCH v1 2/2] iio: adc: add ADC driver for the " Oleksij Rempel
2021-03-05 19:02   ` Jonathan Cameron
2021-03-06 13:28     ` Oleksij Rempel
2021-03-06 14:59       ` Jonathan Cameron
2021-03-09 11:40         ` Oleksij Rempel
2021-03-12 14:09           ` Jonathan Cameron
2021-03-09 11:05     ` Andy Shevchenko
2021-03-09 11:41       ` Oleksij Rempel
2021-03-09 11:46         ` Andy Shevchenko
2021-03-09 12:18           ` Oleksij Rempel
2021-03-09 13:01             ` Andy Shevchenko
2021-03-07 23:05   ` Dmitry Torokhov [this message]
2021-03-09 11:31     ` Oleksij Rempel
2021-03-09 13:21   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEVcO/NeKzBsFEdL@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=david@protonic.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.