From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] inet_parse: Clarify IPv6 comment and error message
Date: Mon, 8 Mar 2021 11:31:10 +0000 [thread overview]
Message-ID: <YEYK/ghnaE9CSG9k@redhat.com> (raw)
In-Reply-To: <20210308002928.3385275-1-dje@google.com>
On Sun, Mar 07, 2021 at 04:29:28PM -0800, Doug Evans via wrote:
> Wrapping an IP address in square brackets does not necessarily
> mean the address is an IPv6 address. The wrapping is just an aid
> to parsing since IPv6 addresses have colons, but does not provide
> semantic information.
> E.g., [127.0.0.1] is a valid way to write 127.0.0.1.
>
> Signed-off-by: Doug Evans <dje@google.com>
> ---
> util/qemu-sockets.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2021-03-08 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 0:29 [PATCH] inet_parse: Clarify IPv6 comment and error message Doug Evans via
2021-03-08 0:33 ` no-reply
2021-03-08 1:31 ` Doug Evans
2021-03-08 11:30 ` Daniel P. Berrangé
2021-03-08 16:05 ` Eric Blake
2021-03-08 11:31 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEYK/ghnaE9CSG9k@redhat.com \
--to=berrange@redhat.com \
--cc=dje@google.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.